On 01/04/2011 06:42 AM, Daniel Veillard wrote:
I must admit I got confused, I locally patched dist.mk to avoid the check but then the modification didn't show up on git status. Moreover ssh and then git to libvirt.org wasn't working this morning from my home (a routing problem because I could access from elsewhere) so I ended up not pushing any patch specific to make syntax-check as part of libvirt 0.8.7 release. I think the right thing to do now is update gnulib (i.e. previous patch) since the release is done.
Agree with updating gnulib now that we are post-release, so I've pushed the first variant. (For that matter, I would have pushed the first variant under the build-breaker rule yesterday, if we hadn't been so close to the release at the time - that's the only reason that I even proposed the second variant.)
Also if you could tag v0.8.7 on my commit with your key that would be nice (my master key is on a few hard drives but all in a box, in a container, on a ship somewhere :-\ I had forgotten this !)
Done (and mentioned in the release announcement thread). -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org