Re: [libvirt] [PATCH 0/2] autogen.sh: Rewrite and modularize
On Wed, Apr 19, 2017 at 09:02:50AM +0200, Andrea Bolognani wrote:
On Tue, 2017-04-18 at 16:41 +0100, Daniel P. Berrange wrote:
> What is it that makes out submodule handling so complicated. eg in gtk-vnc
> and spice-gtk, we have a trivial line in autogen.sh
>
> 'git submodule update --init --recursive'
>
> that takes care of it. Is all the complexity we see caused by the need to
> detect when to re-run bootstrap for gnulib ?
Pretty much, yeah.
This still feels over-engineered to me. I don't really see the benefit in
creating modular files like .submodules/keycodemapdb.functions - it is a
generic facility that is unlikely to ever be needed by anything other than
gnulib.
It feels like we ought to be able to just have the general purpose
submodule update as above, and then just decide if we need to rerun
bootstrap after that
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|