Re: [libvirt] build: fix linking virt-login-shell
On 22.10.2013 09:29, Daniel P. Berrange wrote:
On Mon, Oct 21, 2013 at 03:36:11PM -0600, Jim Fehlig wrote:
> >From a0f35945f3127ab70d051101037e821b1759b4bb Mon Sep 17 00:00:00 2001
> From: Jim Fehlig <jfehlig(a)suse.com>
> Date: Mon, 21 Oct 2013 15:30:02 -0600
> Subject: [PATCH] build: fix virt-login-shell build with apparmor
>
> With libapparmor-devel installed, virt-login-shell fails to link
>
> CCLD virt-login-shell
> ../src/.libs/libvirt-setuid-rpc-client.a(libvirt_setuid_rpc_client_la-vircommand.o):
In function `virExec':
> /home/jfehlig/virt/upstream/libvirt/src/util/vircommand.c:653: undefined reference to
`aa_change_profile'
> collect2: error: ld returned 1 exit status
>
> Fix by linking libvirt_setuid_rpc_client with previously determined
> SECDRIVER_LIBS in src/Makefile.am. While at it, introduce SECDRIVER_CFLAGS
> and use both throughout src/Makefile.am where it makes sense.
>
> Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
> ---
> src/Makefile.am | 16 +++++++---------
> 1 file changed, 7 insertions(+), 9 deletions(-)
ACK to this version of the patch
Daniel
I went ahead and pushed this as it's build breaker which I'm
experiencing everytime I try to build (yes, I do build with AppArmor).
Michal