On 08/30/2013 04:25 PM, Peter Krempa wrote:
On 08/30/13 22:37, Eric Blake wrote:
I noticed from an ./autobuild.sh run that we were installing a virt-login-shell.exe binary when cross-building for mingw, even though such a binary is necessarily worthless since the code depends on lxc which is a Linux-only concept.
* tools/Makefile.am (conf_DATA, bin_PROGRAMS, dist_man1_MANS): Make virt-login-shell installation conditional.
Signed-off-by: Eric Blake <eblake@redhat.com> ---
I'm debating about pushing this under the build-breaker rule.
tools/Makefile.am | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)
ACK and worth fixing this before releasing it.
Thanks; pushed. I'll probably have a similar patch for the virtlockd files that are also tripping up ./autobuild.sh on a mingw rpm, once I can get past my current issue of 'make distcheck' not liking docs/Makefile.am. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org