Re: [PATCH 2/8] conf: Report error when default TPM version is provided

On Mon, Jul 18, 2022 at 11:30:44 +0200, Michal Privoznik wrote: > When "default" version of TPM was provided, our parses accepts it > happily even though the value is forbidden by our RNG and not > documented as accepted value. This is because of < 0 vs <= 0 > comparison of virDomainTPMModelTypeFromString() retval. > > Make the parser error out explicitly in this case. Users can > always chose to not specify the attribute in which case we pick a > sane default (in qemuDomainDefTPMsPostParse()). > > Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; > --- > src/conf/domain_conf.c | 2 +- > src/conf/domain_conf.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) This has the same issue as I've reported in previous patch.