On 04/02/14 05:05, Eric Blake wrote:
A future patch will merge virStorageFileMetadata and virStorageSource, but I found it easier to do if both structs use the same information for tracking whether a source file needs encryption keys.
* src/util/virstoragefile.h (_virStorageFileMetadata): Prepare full encryption struct instead of just a bool. * src/storage/storage_backend_fs.c (virStorageBackendProbeTarget): Use transfer semantics. * src/storage/storage_backend_gluster.c (virStorageBackendGlusterRefreshVol): Likewise. * src/util/virstoragefile.c (virStorageFileGetMetadataInternal): Populate struct. (virStorageFileFreeMetadata): Adjust clients. * tests/virstoragetest.c (testStorageChain): Likewise.
Signed-off-by: Eric Blake <eblake@redhat.com> --- src/storage/storage_backend_fs.c | 6 +++--- src/storage/storage_backend_gluster.c | 6 +++--- src/util/virstoragefile.c | 4 +++- src/util/virstoragefile.h | 3 ++- tests/virstoragetest.c | 4 ++-- 5 files changed, 13 insertions(+), 10 deletions(-)
ACK