Re: [libvirt] [PATCH 6/7] Remove the event namespace concept
On Thu, Dec 12, 2013 at 06:04:06PM +0000, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange(a)redhat.com>
The event namespace concept is mostly redundant information.
With the re-written dispatcher, the namespace is only used
for equality comparisons between event IDs. This can be solved
by just comparing virClassPtr instances instead.
Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
---
src/conf/domain_event.c | 11 +++++++++--
src/conf/network_event.c | 15 +++++++++------
src/conf/object_event.c | 17 ++++++++++++-----
src/conf/object_event.h | 11 +++--------
src/conf/object_event_private.h | 2 ++
5 files changed, 35 insertions(+), 21 deletions(-)
Breaks the build, ACK with this squashed in:
diff --git a/src/conf/object_event.h b/src/conf/object_event.h
index 211defb..23ecb34 100644
--- a/src/conf/object_event.h
+++ b/src/conf/object_event.h
@@ -78,7 +78,7 @@ virObjectEventStateRegisterID(virConnectPtr conn,
void *opaque,
virFreeCallback freecb,
int *callbackID)
- ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(7);
+ ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(8);
int
virObjectEventStateDeregisterID(virConnectPtr conn,
virObjectEventStatePtr state,
--
Martin
Attachments:
- signature.asc (application/pgp-signature — 836 bytes)