Hi Jim,
Thank 's your patch!

After applying the V2 patch, guestVM with tap2 driver-name in xml can be created and works well!!

    <disk type='file' device='disk'>
      <driver name='tap2' type='vhd'/>
      <source file='/root/tapdisk/vhd-f12-2'/>
      <target dev='hda' bus='ide'/>
    </disk>


But dumpxml to the corresponding guestVM still get driver name='tap'
    <disk type='file' device='disk'>
      <driver name='tap' type='vhd'/>
      <source file='/root/tapdisk/vhd-f12-2'/>
      <target dev='hda' bus='ide'/>
    </disk>


I am trying to chase the variable   "def->driverName" located in 
src/domain_conf.c:5452:  virBufferVSprintf(buf, " name='%s'", def->driverName);
to find out why dumpxml still get wrong name

Any hints will be very helpful for me 
Thank you very much!

Regards,
Ben



2010/8/25 Jim Fehlig <jfehlig@novell.com>
benian wrote:
> Hi Jim,
> Thanks for your reply!
>
> I use xm create to create a tap2 disk and it works well
>
> disk = [ 'tap2:vhd:/root/tapdisk/vhd-f12,hda,w']
>
>
> but virsh dumpxml can't get anything about the disk
>
>
> After i apply the patch, i can catch <disk> information by virsh dumpxml
> but it seems that it only recognize "tap" only but not tap2
>
> <disk type='file' device='disk'>
>       <driver name='tap' type='vhd'/>
>       <source file='/root/tapdisk/vhd-f12'/>
>       <target dev='hda' bus='ide'/>
> </disk>
>
> Afterwards i try to use this xml file to virsh create VM  and  no
> active disk is found.

Opps, I forgot to account for tap2 in functions that generate sexpr.  V2
attached.

Regards,
Jim