Re: [libvirt PATCH v2 06/33] systemd: Introduce common templates

On Thu, Sep 28, 2023 at 04:30:03AM -0500, Andrea Bolognani wrote: > On Thu, Sep 28, 2023 at 09:24:11AM +0100, Daniel P. Berrangé wrote: > > On Wed, Sep 27, 2023 at 06:19:07PM +0200, Andrea Bolognani wrote: > > > +++ b/scripts/merge-systemd-units.py > > > @@ -0,0 +1,91 @@ > > > +#!/usr/bin/env python3 > > > > Stick a license header of SPDX tag on this. > > Done (patch below). > > > Also if you didn't already do it, run the file through 'black' > > and let it do whatever it wants todo to formatting. > > It just changed all single quotes into double quotes :) > > > ----- 8< ----- 8< ----- 8< ----- 8< ----- 8< ----- 8< ----- 8< ----- 8< ----- > diff --git a/scripts/merge-systemd-units.py b/scripts/merge-systemd-units.py > index f54c9556c9..bc3321230d 100755 > --- a/scripts/merge-systemd-units.py > +++ b/scripts/merge-systemd-units.py > @@ -1,5 +1,8 @@ > #!/usr/bin/env python3 > > +# Copyright (C) 2023 Red Hat, Inc. > +# SPDX-License-Identifier: LGPL-2.1-or-later > + > import sys > > SECTIONS = [ > ----- >8 ----- >8 ----- >8 ----- >8 ----- >8 ----- >8 ----- >8 ----- >8 ----- Can I consider the patch Reviewed-by: you with the above (and the trivial changes to quotess applied by black) squashed in, or do you want me to send a v3 for that? Everything else is ACKed at this point, but I'm not going to push until 9.9.0 is open for business anyway.