Re: [libvirt] [Qemu-devel] QEMU fstatfs(2) and libvirt SELinux policy
Il 09/03/2012 17:07, Stefan Hajnoczi ha scritto:
> > So am I correct that this extra permission is only needed
for a single
> > RHEL6 release? If qemu won't be doing fstafs on an ongoing basis, it
> > doesn't seem like a good idea to permanently open up the permissions
> > allowed by virt_use_nfs
Paolo, your discard improvements in QEMU add FALLOC_FL_PUNCH_HOLE
support. XFS supports this fallocate() flag in current kernels,
thereby making the XFS-specific support obsolete.
I'm wondering whether it's worth expanding the SELinux policy if we
will have no fstatfs(2) callers in QEMU. Are you planning to drop the
XFS code?
Chris Wedgwood said that on XFS you want to do discard even if the file
is preallocated, while this is not true on other filesystems. So I
guess the detection code should stay.
Paolo