Re: [libvirt] [PATCH] qemu: return -1 on error paths in qemuDomainSaveImageStartVM

On Thu, Jan 28, 2016 at 15:49:48 +0300, Nikolay Shirokovskiy wrote: > The error paths after fix suppose ret == -1 as at the > beginning of the function. > > The better fix would be not to touch 'ret' at all until > the end of the function where it is set to 0. Thus we'd > better introduce some 'rc' variable to hold return > values of called functions. Exactly, it would be much better the way you describe, so why didn't you do it that way? :-)

NACK to this patch. Jirka -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list