Re: [libvirt] [PATCH v2 1/2] virnetdev: fix some issues found by coverity and mingw builds

On Tue, Feb 03, 2015 at 02:27:34PM +0100, Pavel Hrdina wrote:

Commit e562a61a introduced new function to get/set interface state but there was misuse of ATTRIBUTE_NONNULL on non-pointer attributes and also we need to wrap that functions by #ifdef to not break mingw build.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com> --- src/util/virnetdev.c | 36 ++++++++++++++++++++++++------------ src/util/virnetdev.h | 6 +++--- 2 files changed, 27 insertions(+), 15 deletions(-)

ACK Jan