On 09/16/13 23:42, Eric Blake wrote:
On 09/10/2013 04:15 AM, Peter Krempa wrote:
--- src/libvirt_private.syms | 1 + src/util/virxml.c | 33 +++++++++++++++++++++++++++++++++ src/util/virxml.h | 2 ++ 3 files changed, 36 insertions(+)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 0631941..18e9a4b 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -2091,6 +2091,7 @@ virUUIDParse;
# util/virxml.h virXMLChildElementCount; +virXMLNodeDump;
Interesting name; I don't know that I would come up with much better (ToString is longer to type than Dump).
I went with virXMLNodeToString despite it's longer I liked it better.
+ +/** + * virXMLNodeDump: convert a XML node ptr to a XML string
Silly English. The rule is "an" before a leading vowel sound, and since "XML" is pronounced "ex-em-ell", there's a leading vowel sound.
Good to know that it's based on the sound and not on the actual letter. That's what they don't teach at school here.
s/a XML/an XML/2
ACK with comment fix.
Fixed && pushed; Thanks Peter