Re: [libvirt] [PATCH 4/5] conf: track more fields in backing chain metadata

On 04/04/2014 03:31 AM, Peter Krempa wrote: >> struct _virStorageFileMetadata { >> - char *backingStore; /* Canonical name (absolute file, or protocol) */ >> - char *backingStoreRaw; /* If file, original name, possibly relative */ >> - char *directory; /* The directory containing basename of backingStoreRaw */ >> - int backingStoreFormat; /* enum virStorageFileFormat */ >> - bool backingStoreIsFile; >> + /* Name of this file as spelled by the user (top level) or >> + * metadata of the parent (if this is a backing store). */ >> + char *path; >> + /* Canonical name of this file, used to detect loops in the >> + * backing store chain. */ >> + char *canonName; >> + /* Directory to start from if backingStoreRaw is a relative file >> + * name */ >> + char *relDir; >> + /* Name of the backing store recorded in metadata of the parent */

>> + char *backingStoreRaw; > > Hmm, this field seems pretty redundant to me, IIUC it's the same data as > in "path". No, it's not. Given the chain: base <- top my goal is to have: { .path = "top", .canonName = "/path/to/top", .relDir = ".", .backingStoreRaw = "base", .backingMeta = { .path = "base", .canonName = "/path/to/base", .relDir = ".", .backingStoreRaw = NULL, .backingMeta = NULL, } }