Re: [libvirt] [PATCHv2 00/14] vcpu - distinguish maximum from current
On 10/13/2010 11:53 AM, Eric Blake wrote:
Version 1 had ACKs on most of the patches, but raised several points
(not the least of which was a lack of testing). I've now done more
testing on xen than on qemu, so there may still be some qemu quirks.
Version 2 of the patch series; this addresses most of the points
from v1 (http://thread.gmane.org/gmane.comp.emulators.libvirt/28520).
I'm thinking that it is possible to backport _just_ patches 1 (add
current attribute), 7 (add maxvcpus to xml), and 12 (xen xm and sexpr
support) to make RHEL 5 xen support the distinction at the XML layer
without the expense of an API addition (that is, the existing dumpxml
API is sufficient to expose the core change in this patch series, and
the remaining patches in the series are just sugar to make it easier).
However, I still have to test that theory.
That theory has now been tested - it only took a few minor tweaks to
backport just those three patches for XML support without new API
support. However, I don't suggest reordering patches when applying this
series upstream.
I also have one patch to write - namely, making xen support
virDomainSetVcpusFlags. But I'd rather get the review going
on the rest of these patches, since it's now the last remaining
0.8.5 candidate feature.
That patch is now submitted (as 15/14), and I've done more testing on
xen and the test driver.
Still to come - a patch to replace docs/api_extension with a more
up-to-date example by using this patch series :)
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org