Re: [libvirt PATCH v2 3/3] gitlab-ci.yml: Add an explicit env variable to mark a job as broken

14 Jan 2021

      On Thu, 2021-01-14 at 12:03 +0100, Erik Skultety wrote:
...
rules:
+    - if: "$JOB_TEMPORARY_DISABLED"
+      allow_failure: true
[...]
   rules:
+    - if: "$TEMPORARY_DISABLE"
+      allow_failure: true
[...]
   rules:
+    - if: "$TEMPORARY_DISABLED"
+      allow_failure: true
Please pick *one* name and stick to it.

I recommend either "TEMPORARILY_DISABLED" or
"JOB_TEMPORARILY_DISABLED", with the order in which I've listed them
reflecting my preference.

You also need to add these rules: to .container_job_template, since
temporarily disabling specific container builds is a valid use case.

-- 
Andrea Bolognani / Red Hat / Virtualization