Re: [libvirt] [PATCH v3 22/48] network: introduce virtnetworkd daemon

> On 30 Jul 2019, at 13:20, Daniel P. Berrangé <berrange(a)redhat.com&gt; wrote: > > On Tue, Jul 30, 2019 at 01:08:53PM +0200, Christophe de Dinechin wrote: >> >> Daniel P. Berrangé writes: >> >>> The virtnetworkd daemon will be responsible for providing the network API >>> driver functionality. The network driver is still loaded by the main >>> libvirtd daemon at this stage, so virtnetworkd must not be running at >>> the same time. >>> >>> Reviewed-by: Andrea Bolognani <abologna(a)redhat.com&gt; >>> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com&gt; >>> --- >>> .gitignore | 4 ++ >>> libvirt.spec.in | 8 ++++ >>> src/network/Makefile.inc.am | 61 +++++++++++++++++++++++++++++ >>> src/network/virtnetworkd.service.in | 25 ++++++++++++ >>> 4 files changed, 98 insertions(+) >>> create mode 100644 src/network/virtnetworkd.service.in >>> diff --git a/src/network/virtnetworkd.service.in b/src/network/virtnetworkd.service.in >>> new file mode 100644 >>> index 0000000000..656e8b4f84 >>> --- /dev/null >>> +++ b/src/network/virtnetworkd.service.in >>> @@ -0,0 +1,25 @@ >>> +[Unit] >>> +Description=Virtualization network daemon >>> +Conflicts=libvirtd.service >>> +Requires=virtnetworkd.socket >>> +Requires=virtnetworkd-ro.socket >>> +Requires=virtnetworkd-admin.socket >>> +After=network.target >>> +After=dbus.service >>> +After=apparmor.service >>> +After=local-fs.target >>> +Documentation=man:libvirtd(8) >> >> Maybe you need to create man page aliases for each of the new daemon names? > > Yes, I need to figure out a way to auto-generate the man page for each > daemon with irrelevant content stripped. Or simply refdirect to the original man page, using the .so macro? In which case you could generate the man page with a rule like: echo “.so $LIBVIRTD_MANPAGE” > $@ (But then, maybe you really want per-daemon man page…)