Re: [libvirt] [PATCH v2 1/5] configure: Require GnuTLS

On Tue, 2018-06-12 at 11:41 +0100, Daniel P. Berrangé wrote: > On Tue, Jun 12, 2018 at 12:24:14PM +0200, Andrea Bolognani wrote: > > I've started building Docker containers with all libvirt build > > dependencies already installed[1], mainly for use in Travis CI; > > the CentOS 7 container could easily be used to also solve the > > issue at hand. > > > > I've already tried building libvirt inside said container on a > > CentOS 6 host running Docker from EPEL without encountering any > > issue; all that's left to do is install Docker on libvirt.org > > and script the integration, which shouldn't be too difficult. > > > > Does that sound like a sensible way forward? > > AFAIK, Docker is explicitly unsupported on CentOS 6 now. > > https://github.com/moby/moby/issues/14365 Yeah, the Docker version available in CentOS 6 EPEL is fairly old and I doubt it's getting a lot of updates these days. That said, we would be using it exclusively with images we've crafted ourselves starting from official (and thus arguably trustworthy) base images, and only to run build jobs locally, so I'm not sure there's much to be concerned about security-wise. > I was actually intending to take a simpler approach - just compile a > newer gnutls into /opt and let the website build use that. Sure, that would probably do the trick as far as libvirt.org itself is concerned; however, we would not only have to keep CentOS 6 around in the CentOS CI environment, but also figure out a way to reproduce the same hack there if we want to make sure changes in libvirt don't accidentally break building the website.