05-Jan-17 19:52, John Ferlan пишет:
Since this has been sitting unreviewed for a while...
On 12/09/2016 09:28 AM, Maxim Nestratov wrote:
By a mistake, 'delay' libvirt xml parameter was converted to 'discard' QEMU command line string one.
Test "kvm-pit-delay" is fixed accordinly, so that redundant test cases removed as there is no need to specify both QEMU_CAPS_NO_KVM_PIT and QEMU_CAPS_KVM_PIT_TICK_POLICY simultaneusly in tests as they are mutually exclusive and "kvm-pit-device" becomes just the same as "kvm-pit-delay". I'd like to alter the commit to be:
qemu: Fix pit timer tick policy=delay
By a mistake, for the VIR_DOMAIN_TIMER_TICKPOLICY_DELAY qemu command line creation, 'discard' was used instead of 'delay' in commit id '1569fa14'.
Test "kvm-pit-delay" is fixed accordingly to show the correct option being generated.
Remove the (now) redundant kvm-pit-device tests. As it turns out there is no need to specify both QEMU_CAPS_NO_KVM_PIT and QEMU_CAPS_KVM_PIT_TICK_POLICY since they are mutually exclusive and "kvm-pit-device" becomes just the same as "kvm-pit-delay".
...
ACK - (let me know if you agree with the adjust commit - I can push if you would like, although I know you have that access.)
John
Agree with the your changes and don't mind if you push it. Maxim