On 02/09/2017 04:21 PM, Boris Fiuczynski wrote:
On 02/09/2017 09:01 AM, Michal Privoznik wrote:
On 02/07/2017 04:16 PM, Boris Fiuczynski wrote:
Since a successful completion of openvswitch calls is expected a longer timeout should be able to be chosen in order to account for loaded systems. Therefore this patch series provides the ability to specify the timeout value for openvswitch calls in the libvirtd configuration file.
Boris Fiuczynski (3): libvirtd: add openvitch timeout value network: allow to specify timeout for openvswitch calls libvirtd: set openvswitch timeout value based on config data
daemon/libvirtd-config.c | 6 ++++ daemon/libvirtd-config.h | 2 ++ daemon/libvirtd.aug | 1 + daemon/libvirtd.c | 13 +++++++++ daemon/libvirtd.conf | 9 ++++++ daemon/test_libvirtd.aug.in | 1 + src/libvirt_private.syms | 1 + src/util/virnetdevopenvswitch.c | 64 +++++++++++++++++++++++++++++++++++------ src/util/virnetdevopenvswitch.h | 5 ++++ 9 files changed, 94 insertions(+), 8 deletions(-)
I've fixed all the issues I've found and was about to push it. But then I realized: docs/news.xml entry is missing. I can't push it without it, sorry. I can't do it to our news police :-) Just reply with proposed news entry and I can fix that.
Michal
Well, it was worth a try... Just kidding! :-)
Ha ha.
It's a miss on my side. Sorry about it.
No problem. It's a new concept. Even us, full time contributors often forget about that.
Here is my proposal:
<change> <summary> network: make openvswitch call timeout configurable </summary> <description> Adding the ability to specify the timeout value in seconds for openvswitch calls in the libvirtd configuration file. </description> </change>
Yeah, this will do. Pushed. Thanks. Michal