Re: [libvirt] [PATCH 0/6] syntax-check: Introduce a new rule to check misaligned stuff and fix it (batch I)
On 09/25/2018 02:03 PM, Ján Tomko wrote:
On Mon, Sep 24, 2018 at 03:30:02PM +0200, Michal Privoznik wrote:
> On 09/24/2018 03:14 PM, Ján Tomko wrote:
>> Please no.
>>
>> Despite my comments on the first spacing rule [0], this series slows
>> down the spacing check by 100 % (from 1.6s to 3.1s in my case).
>
> I don't think that syntax-check run time is our goal.
Well that's just sad.
Why is that? I spend more time trying to figure our what the code does
than running syntax-check over it. Therefore in my view code cleanliness
is more important. But if you provide some argument otherwise we can
certainly discuss it.
Michal