[libvirt PATCH 2/2] tests: don't set G_DEBUG=fatal-warnings on macOS

On macOS when BROKEN_POLL is set in GLib, our tests will periodically trigger a warning: (process:50880): GLib-WARNING **: 02:54:15.272: poll(2) failed due to: Bad file descriptor. Our code is inherantly racy, calling g_source_destroy which removes the FD from the event thread poll asynchronously but we close the FD immediately after g_source_destroy returns. With poll() this results in POLLNVAL which we're ignoring, but with select() it generates the BADF error on macOS. We need to ignore the warnings on macOS to avoid abort()ing our test programs. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com&gt; --- tests/meson.build | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/tests/meson.build b/tests/meson.build index fd78d8a2fd..08d2ae67cb 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -39,9 +39,24 @@ tests_env = [ &#39;abs_top_srcdir=@0(a)&#39;.format(meson.source_root()), 'LC_ALL=C', 'LIBVIRT_AUTOSTART=0', - 'G_DEBUG=fatal-warnings', ] + +# On macOS when BROKEN_POLL is set for GLib, our tests will +# periodically trigger a warning: +# +# (process:50880): GLib-WARNING **: 02:54:15.272: poll(2) failed due to: Bad file descriptor. +# +# Our code is inherantly racy, calling g_source_destroy which +# removes the FD from the event thread poll asynchronously +# but we close the FD immediately after g_source_destroy returns. +# +# With poll() this results in POLLNVAL, but with select() it +# generates the BADF error on macOS +if host_machine.system() != 'darwin' + tests_env += ['G_DEBUG=fatal-warnings'] +endif + if use_expensive_tests tests_env += 'VIR_TEST_EXPENSIVE=1' else -- 2.35.1