Re: [PATCH 13/17] virDomainTPMDefParseXML: Switch to virXMLPropEnumDefault()
On 5/23/22 3:08 PM, Michal Privoznik wrote:
The virDomainTPMDefParseXML() function uses old style of parsing
XML (virXMLPropString + str2enum conversion). Use
virXMLPropEnumDefault() which encapsulates those steps.
virXMLPropEnum and virXMLPropEnumDefault
Signed-off-by: Michal Privoznik<mprivozn(a)redhat.com>
---
src/conf/domain_conf.c | 43 ++++++++++++----------------------------
src/conf/domain_conf.h | 6 +++---
src/qemu/qemu_command.c | 2 +-
src/qemu/qemu_domain.c | 2 +-
src/qemu/qemu_validate.c | 1 +
5 files changed, 19 insertions(+), 35 deletions(-)
Besides above and what I commented in patch 4
Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com>
--
Mit freundlichen Grüßen/Kind regards
Boris Fiuczynski
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294