On 03/12/2014 10:04 PM, Laine Stump wrote:
This should be squashed into the first patch of the previous "eliminate hardcoded indent" series (which was ACKed but hasn't yet been pushed):
https://www.redhat.com/archives/libvir-list/2014-March/msg00361.html
The initial patch neglected to change the functions that format private metadata in the qemu and lxc domain xml.
I have verified that make check still passes when these changes are squashed into the original. --- src/conf/domain_conf.c | 2 +- src/lxc/lxc_domain.c | 4 ++-- src/qemu/qemu_domain.c | 45 +++++++++++++++++++++++++++------------------ 3 files changed, 30 insertions(+), 21 deletions(-)
ACK. Hmm, your comment about dropping all the virBufferAdjustIndent() calls, free-form output of the text without regards to indentation, then running it through util/virxml.c to parse and then pretty-print the xml, may be more maintainable, even if it eats more CPU cycles. But if we do that, it could be a followup to this series. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org