On 2012年11月27日 15:08, Osier Yang wrote:
On 2012年11月26日 19:26, Paolo Bonzini wrote:
Il 26/11/2012 11:38, Daniel P. Berrange ha scritto:
Since "rawio" and "unpriv_sgio" are only valid for "lun", this I think that's a ugly attribute name, just use 'sgio'.
That doesn't explain what it is for.
Yeah, I used "sgio" in the first drafts, but changed to "unpriv_sgio" afterwards, for realizing it can't tell what the tag does internally.
Some possibilities:
- filter-scsi-commands=yes/no
- cdb-filter=yes/no
- privileged-scsi-commands=allow/deny
- cdb=allow-all/filter
As far as I get from your kernel patches, the unpriv_sgio allows any SG_IO commands for unprivileged users, without filtering.
Or do you plan to introduce filtering in future? It sounds good to use "cdbFitler" if so.
So I'm wondering if using the term "CBD filter" matches the exact meaning.
Regards, Osier
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list