On 09/02/2011 03:57 AM, Daniel Veillard wrote:
On Thu, Sep 01, 2011 at 10:24:37PM -0600, Eric Blake wrote:
> I think I've addressed most findings from round 3 - by implementing
Review:
1 ACK
2 ACK
3,4,5,6: New flags in API ACK, it would be good to have regression tests
tracking all the events sent in the various cases...
7, 8 ACK
2-8 now pushed for BZ 733762; hopefully, everyone is okay with me doing
self-review and amendments to patch 6 and 7 along the way. (When the
patch series is this big, I've flushed enough mental state along the way
to be reviewing my own patches from a much cleaner condition than usual
for a single patch, so I'm actually finding good fixes :)
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org