Re: [libvirt] [PATCH]: qemu_driver: convert uuid to string in error messages

On Fri, Jul 25, 2008 at 05:02:43AM -0400, Daniel Veillard wrote: > On Fri, Jul 25, 2008 at 09:29:43AM +0100, Daniel P. Berrange wrote: > > On Thu, Jul 24, 2008 at 03:52:32PM -0400, Guido G?nther wrote: > > > Hi, > > > qemu_driver misses some conversions to a char* before printing the uuid. > > > Possible fix attached. > > > > ACK, surprised that the printf() format checks don't complain about > > passing an unsigned char to a %s format in GCC. This is actually > > one of the things ICC flagged when i tried it, but I never fixed it > > Applied, i just had to add an include for uuid.h to avoid an undeclared > function warning :-) The hunk including uuid.h accidently endet up in 0001-also-check-domain-uuid-on-create.patch, sorry about that.