16 Apr
2018
16 Apr
'18
4:31 a.m.
On Fri, Apr 13, 2018 at 04:47:12PM +0200, Michal Privoznik wrote:
If a function is disposing virSomething it should be called virSomethingDispose(). There are two offenders: virCapabilitiesDispose(virCapsPtr) and virDomainXMLOptionClassDispose(virDomainXMLOptionPtr).
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> ---
An idea for a related patch: there are a few violators that put "virSomethingClass" is the name of the class, while the general trend is to omit "Class" from the name (it also doesn't make that much sense to have it there). Reviewed-by: Erik Skultety <eskultet@redhat.com>