Re: [PATCH 2/4] qapi/migration: Deprecate migrate argument @detach

Peter Xu <peterx(a)redhat.com&gt; writes: > On Wed, May 21, 2025 at 08:37:09AM +0200, Markus Armbruster wrote: >> Argument @detach has always been ignored. Start the clock to get rid >> of it. >> >> Cc: Peter Xu <peterx(a)redhat.com&gt; >> Cc: Fabiano Rosas <farosas(a)suse.de&gt; >> Signed-off-by: Markus Armbruster <armbru(a)redhat.com&gt; >> --- >> docs/about/deprecated.rst | 5 +++++ >> qapi/migration.json | 18 +++++++++--------- >> 2 files changed, 14 insertions(+), 9 deletions(-) >> >> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst >> index 9665bc6fcf..ef4ea84e69 100644 >> --- a/docs/about/deprecated.rst >> +++ b/docs/about/deprecated.rst >> @@ -179,6 +179,11 @@ Use ``job-dismiss`` instead. >> >> Use ``job-finalize`` instead. >> >> +``migrate`` argument ``detach`` (since 10.1) >> +'''''''''''''''''''''''''''''''''''''''''''' >> + >> +This argument has always been ignored. >> + >> ``query-migrationthreads`` (since 9.2) >> '''''''''''''''''''''''''''''''''''''' >> >> diff --git a/qapi/migration.json b/qapi/migration.json >> index 8b9c53595c..ecd266f98e 100644 >> --- a/qapi/migration.json >> +++ b/qapi/migration.json >> @@ -1660,6 +1660,10 @@ >> # >> # @resume: resume one paused migration, default "off". (since 3.0) >> # >> +# Features: >> +# >> +# @deprecated: Argument @detach is deprecated. >> +# >> # Since: 0.14 >> # >> # .. admonition:: Notes >> @@ -1668,19 +1672,14 @@ >> # migration's progress and final result (this information is >> # provided by the 'status' member). >> # >> -# 2. All boolean arguments default to false. > > There's one more boolean ("resume") exists, but probably not a huge > deal.. All booleans if not mentioned should have a default-false semantics > at least to me. Its default remains documented. It's visible above :)