Re: [libvirt] [PATCH v3] travis: switch to using Ubuntu 16.04 and 18.04
On Thu, Jun 07, 2018 at 02:37:34PM +0200, Andrea Bolognani wrote:
On Thu, 2018-06-07 at 10:55 +0100, Daniel P. Berrangé wrote:
> The container images provided by Travis only support Ubuntu 14.04,
> however, Travis has ability to run docker, which allows the build
> script to use arbitrary OS images. This takes advantage of that to
> convert the build over to Ubuntu 16.04 and 18.04
>
> This is using the official Ubuntu provided images and installing
> extra build deps required, as we previously did with Travis container
> images.
I still believe the commit message should be snipped here, but you
seem to be very keen on keeping the extra paragraphs around :)
Mostly because I keep forgetting.... I'm reading your comments making
the changes to the commit, and when I'm done & ammend the commit, I
forget there was a comment right at the start about the commit message.
I really will delete it before pushing :-)
Everything else looks good now, so
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|