Re: [libvirt] [PATCH 08/10] list: Change MATCH for common use in virsh
On 09/04/2012 09:16 AM, Osier Yang wrote:
Move definition of MATCH from virsh-domain-monitor.c into
virsh.h for further use.
---
tools/virsh-domain-monitor.c | 2 --
tools/virsh.h | 2 ++
2 files changed, 2 insertions(+), 2 deletions(-)
Not quite right.
+++ b/tools/virsh.h
@@ -47,6 +47,8 @@
# define GETTIMEOFDAY(T) gettimeofday(T, NULL)
+# define MATCH(FLAG) (flags & (FLAG))
If you're going to make the macro reusable, I think it would be better
to put it in the VSH_ namespace, and update all existing callers.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 617 bytes)