On 04/25/2012 01:16 PM, Alex Jia wrote:
On 04/25/2012 12:04 PM, Guannan Ren wrote:
On 04/25/2012 11:00 AM, Osier Yang wrote:
On 2012年04月24日 17:40, Guannan Ren wrote:
--- cases/basic_interface.conf | 2 +- cases/consumption_cpu_topology.conf | 6 +-- cases/consumption_domain_nfs_start.conf | 7 +--- cases/consumption_eventhandler.conf | 6 +-- cases/consumption_libvirtd.conf | 6 +-- cases/consumption_ownership_test.conf | 7 +--- cases/domain_linux_net_inst.conf | 11 ++---- cases/linux_domain.conf | 48 +++++++++++++------------------ cases/snapshot.conf | 8 ++-- cases/storage_dir.conf | 7 ---- cases/storage_disk.conf | 2 - cases/storage_iscsi.conf | 13 ++++---- cases/storage_logical.conf | 5 --- cases/storage_mpath.conf | 2 - cases/storage_netfs.conf | 13 +------- cases/storage_scsi.conf | 2 - cases/windows_domain.conf | 35 +++++----------------- 17 files changed, 55 insertions(+), 125 deletions(-)
Can you explain each change type? I'm not able to review it without that, e.g. why "virt_type" is not needed anymore.
Osier
basic_interface.conf: the original usage is not right, use 'ethernet' for the default ifacetype.
consumption_cpu_topology.conf, consumption_domain_nfs_start.conf consumption_eventhandler.conf, consumption_libvirtd.conf consumption_ownership_test.conf, domain_linux_net_inst.conf linux_domain.conf, snapshot.conf
The above testcase config file, virt-type is removed because 'kvm' is set to default value. or, we only have xml file of kvm version, 'xen' or other type need to be updated later. Although 'kvm' is a default hypervisor, If we plan to support other hypervisors, we should reserve virt-type argument, IMO, it will be flexible and easy to extend in the future.
I agree, this is the result of cleanup work, it make it easier to add support to other hypervisor, so, if we need it, the patch could be easy to write. Guannan Ren