Re: [libvirt] [PATCH 1 of 3] [LXC] Add functions to manage veth device pairs
On Thu, Jun 19, 2008 at 10:46:40AM -0700, Dan Smith wrote:
DV> Hum, it's not only a kernel feature, it looks more like a
DV> dependancy on iproute, maybe that can be checked at runtime when
DV> initializing the lxc module, no ?
I suppose I could actually let it fail when it tries to do the actual
move. Would you rather a specific test during the define stage to
reject the <interface> if the non-netns 'ip' command is found?
Well i was wondering if you could not try to detect if the feature
is available for example in lxcProbe() then keep the status.
DV> yeah I'm getting very confused by that code :-)
Agreed, I'll fix it up :)
okay :-)
DV> as the header template for the two new files to match the
other files.
DV> COPYING.LIB is of course LGPL 2.1
Okay, I'll change it.
Cool, thanks !
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/