Re: [libvirt] [PATCH 2/2] snapshot: wire up qemu transaction command

On 03/17/2012 10:27 PM, Eric Blake wrote: > The hardest part about adding transactions is not using the new > monitor command, but undoing the partial changes we made prior > to a failed transaction. >

> + if (virSecurityManagerRestoreImageLabel(driver->securityManager, > + vm->def, disk)< 0) > + VIR_WARN("Unable to restore security label on %s", disk->src); > + if (virDomainLockDiskDetach(driver->lockManager, vm, disk)< 0) > + VIR_WARN("Unable to release lock on %s", source); > + if (need_unlink&& stat(disk->src,&st) == 0 > +&& st.st_size == 0&& S_ISREG(st.st_mode)&& unlink(disk->src)< 0) > + VIR_WARN("Unable to release lock on %s", disk->src); Is this second warning correct? It looks to me like if you are unlinking the disk source file, but the error message states that lock release failed.

I don't have many experience working with the locking and security code, but this funcion looks as it's doing what it should. I'd feel more confident if somebody other would look at this part. ACK to the rest, and a not-so-confident ACK of the marked part if my question gets cleared.