Re: [libvirt] [PATCH 1/2] add ebtables wrapper

On Tue, 2009-11-03 at 23:17 +0100, Daniel Veillard wrote: > On Tue, Oct 27, 2009 at 12:36:09PM +0100, Gerhard Stenzel wrote: > > This patch adds the files which implement the ebtables wrapper. > > > > Signed-off-by: Gerhard Stenzel <gerhard.stenzel(a)de.ibm.com&gt; ... > > +/** > > + * ebtablesSaveRules: > > + * @ctx: pointer to the EB table context > > + * > > + * Saves all the EB table rules associated with a context > > + * to disk so that if ebtables is restarted, the rules > > + * will automatically be reload. > > + */ > > +void > > +ebtablesSaveRules(ebtablesContext *ctx) > > +{ > > + ebtRulesSave(ctx->input_filter); > > + ebtRulesSave(ctx->forward_filter); > > + ebtRulesSave(ctx->nat_postrouting); > > +} > > Hum, and where ? Under /etc/libvirt/ebtables/.... ? > > Are the table and chain names provided in ebtRulesNew() sufficient > to uniquely name the set ? I hope so otherwise we're gonna have trouble > with persistance. It would be good to have ebtRulesSave() documented if > not fully finished before next release. > > I'm gonna commit this, but I think we need to double-check that the > current APIs won't be a problem when we want to implement saving (didn't > checked the second patch yet). > > I also think the spec file should add a Requires to ebtables as this > is not installed systematically (it wasn't present on my workstation > by default). > > I will push this tonight, > > thanks ! > > Daniel > This patch removes the ebtablesSaveRules() function as it more confusing than useful at the moment.