Re: [libvirt] [PATCH 01/15] Introduce virDomainSuspendFlags

On 02/03/2014 09:16 AM, Michal Privoznik wrote: > So far, we have just bare virDomainSuspend() API that suspends a domain. > However, in the future there might occur a case, in which we may want > to modify suspend behavior slightly. In that case, @flags are useful. > > Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; > --- > include/libvirt/libvirt.h.in | 2 ++ > src/driver.h | 5 +++++ > src/libvirt.c | 49 ++++++++++++++++++++++++++++++++++++++++---- > src/libvirt_public.syms | 5 +++++ > src/remote/remote_driver.c | 1 + > src/remote/remote_protocol.x | 13 +++++++++++- > src/remote_protocol-structs | 5 +++++ > 7 files changed, 75 insertions(+), 5 deletions(-) Back when we added virDomainShutdownFlags in 0.9.10, I asked if we should also add *Flags variants for remaining functions without them; at the time, we decided against it, but I'm not quite sure why. I'm perfectly fine with adding this for the sake of making future additions easier, even if we don't have a use for the flags now - it's easier to support a flag than it is to rebase to pick up a new function for any situation where the .so contains a flags function, but it may be worth getting a second opinion before pushing, if you don't have a plan to use flags right away.