Re: [libvirt] [PATCH v2 1/4] qemu: refactor qemuDomainMachine* functions

On Tue, Apr 18, 2017 at 13:37:26 +0200, Pavel Hrdina wrote: > Introduce new wrapper functions without *Machine* in the function > name that take the whole virDomainDef structure as argument and > call the existing functions with *Machine* in the function name. > > Change the arguments of existing functions to *machine* and *arch* > because they don't need the whole virDomainDef structure and they > could be used in places where we don't have virDomainDef. > > Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com&gt; > --- > > New in v2: > - add a wrappers that extract required data from virDomainDef structure This should have been split into the rename patch and then into addition of the new wrappers. Calling this "refactor" is a convenient way to avoid doing that.

ACK regardless.