Re: [libvirt] [PATCH] Fix common misspellings
On Fri, Mar 20, 2015 at 01:47:01PM +0100, Ján Tomko wrote:
On Fri, Mar 20, 2015 at 01:21:06PM +0100, Martin Kletzander wrote:
> Wikipedia's list of common misspellings [1] has a machine-readable
> version. This patch fixes those misspellings mentioned in the list
> which don't have multiple right variants (as e.g. "accension", which
can
> be both "accession" and "ascension"), such misspellings are left
Thankfully, none of the three spellings are present in the git.
That was just a example (see that "e.g."), there are 206 of those.
You made me to go through those as well, all except one were false
positives (e.g. '"$@" -Wc,+Maked'), so I squashed this in:
diff --git i/src/util/virhostdev.c w/src/util/virhostdev.c
index 9678e2b..23365a3 100644
--- i/src/util/virhostdev.c
+++ w/src/util/virhostdev.c
@@ -569,7 +569,7 @@ virHostdevPreparePCIDevices(virHostdevManagerPtr hostdev_mgr,
/* The device is in use by other active domain if
* the dev is in list activePCIHostdevs. VFIO devices
- * belonging to same iommu group cant be shared
+ * belonging to same iommu group can't be shared
* across guests.
*/
if (STREQ(virPCIDeviceGetStubDriver(dev), "vfio-pci")) {
--
> untouched. The list of changes was manually re-checked for
false
> positives.
>
> [1]
https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_...
>
> Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
> ---
> This is in no way automated, it's merely a check on whether this makes
> sense. Also I left out three words and two files which I thought
> might not be what we want.
>
> docs/bugs.html.in | 2 +-
> docs/contact.html.in | 2 +-
> docs/schemas/basictypes.rng | 2 +-
> docs/schemas/interface.rng | 2 +-
> docs/securityprocess.html.in | 6 +++---
> examples/systemtap/lock-debug.stp | 2 +-
> include/libvirt/libvirt-host.h | 2 +-
> include/libvirt/virterror.h | 2 +-
> src/bhyve/bhyve_driver.c | 6 +++---
> src/cpu/cpu_powerpc.c | 2 +-
> src/datatypes.c | 4 ++--
> src/network/bridge_driver_linux.c | 2 +-
> src/qemu/THREADS.txt | 2 +-
> src/qemu/qemu_capabilities.c | 2 +-
> src/qemu/qemu_driver.c | 2 +-
> src/util/virfirewall.c | 2 +-
> src/util/virprocess.c | 2 +-
> src/vbox/vbox_common.c | 2 +-
> src/vbox/vbox_common.h | 2 +-
> src/xen/xend_internal.c | 2 +-
> src/xenconfig/xen_xm.c | 2 +-
> tools/wireshark/samples/libvirt-sample.pdml | 2 +-
> 22 files changed, 27 insertions(+), 27 deletions(-)
>
> diff --git a/docs/bugs.html.in b/docs/bugs.html.in
> index 140d1b4..55ceb60 100644
> --- a/docs/bugs.html.in
> +++ b/docs/bugs.html.in
> @@ -11,7 +11,7 @@
>
> <p>
> If you think that an issue with libvirt may have security
> - implications, <strong>please do not</strong> publically
> + implications, <strong>please do not</strong> publicly
> report it in the bug tracker, mailing lists, or irc. Libvirt
> has <a href="securityprocess.html">a dedicated process for
handling (potential) security issues</a>
> that should be used instead. So if your issue has security
I'm not convinced 'publically' is wrong, but 'publicly' is much more
common.
"publically" looks/sounds very weird to me, but I can't say for sure
whether it's "just plain wrong" or if the rules are just old. But
there were worse ones than that.
I've left out "ok" (which should be OK, but it looks like nobody cares
and there were *so many* false positives in the code), and there's
"(in)dependant" where it suggests s/dant/dent/ and I couldn't find
anywhere that the version with 'a' is wrong, but I see a lot of
consistent usage of that and even my spell-checker doesn't mark it as
wrong.
I'll leave out the public+ally if someone strongly disagrees.
ACK
Thanks for the review. I was thinking some more native speaker will
have a look as well, so I'll wait for a while if there are any
oppositions to this.
Jan
--
libvir-list mailing list
libvir-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Attachments:
- attachment.sig (application/pgp-signature — 819 bytes)