Jim Meyering wrote:
"Richard W.M. Jones" <rjones@redhat.com> wrote:
This small patch fixes some bugs in the handling of the field string in virDomainGetSchedulerParameters and makes a similar pre-emptive fix to virDomainSetSchedulerParameters.
Also, please don't use !strcmp(a,b), because it confuses me. Better is to write strcmp(a,b) == 0 to mean "strings match" and strcmp(a,b) != 0 to mean "strings don't match".
Hi Rich,
I agree, but prefer to avoid direct use of strcmp altogether. I use this definition:
#define STREQ(a, b) (strcmp (a, b) == 0)
Then all uses are either STREQ(a, b) or ! STREQ(a, b)
Let's try this updated patch. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903