Re: [libvirt] [PATCH v4 04/13] XML parsing for memory tunables
On Wed, Oct 13, 2010 at 10:39:00AM +0530, Nikunj A. Dadhania wrote:
On Tue, 12 Oct 2010 16:54:39 +0200, Daniel Veillard
<veillard(a)redhat.com> wrote:
> anyway once cleaned up the patch makes sensei, ACK, but please use
> "make syntax-check" and do not configure out drivers when you are
> developping patches,
>
Thanks Daniel,
Did not know about the make syntax-check. And as you guessed, I did not
compile it for other drivers, just went out of my mind, I will take care next
time.
Okay, HACKING in the git checkout and http://libvirt.org/hacking.html
gives a set of advices for people developping patches it lists
"make syntax-check" and also suggestsi
./configure --enable-compile-warnings=error
which would likely have caught the C&P error in the remote code.
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/