From soniaverma9727 at gmail.com Tue May 17 05:26:53 2016 Content-Type: multipart/mixed; boundary="===============1049311262858447593==" MIME-Version: 1.0 From: sonia verma To: devel at lists.libvirt.org Subject: Re: [libvirt] [PATCH] lxc: support Date: Tue, 17 May 2016 14:56:47 +0530 Message-ID: In-Reply-To: 1463415677-21183-1-git-send-email-laine@laine.org --===============1049311262858447593== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Laine The above patch of interface type=3D"ethernet" is for which libvirt version? On Mon, May 16, 2016 at 9:51 PM, Laine Stump wrote: > This is identical to type=3D'bridge', but without the "connect to a > bridge" part, so it can be handled by using the same functions (and > often even the same cases in switch statements), after renaming > virLXCProcessSetupInterfaceBridged() to virLXCProcessInterfaceTap() > and enhancing it to skip bridge-related items when brname =3D=3D NULL. > > To be truly useful, we need to support setting the ip address on the > host side veth as well as guest side veth (already supported for > type=3D'bridge'), as well as setting the peer address for both. > > The