From crobinso at redhat.com Mon May 16 18:53:33 2016
Content-Type: multipart/mixed; boundary="===============0938652454589179466=="
MIME-Version: 1.0
From: Cole Robinson <crobinso at redhat.com>
To: devel at lists.libvirt.org
Subject: Re: [libvirt] [PATCH] lxc: support <interface type='ethernet'>
Date: Mon, 16 May 2016 18:53:32 -0400
Message-ID: <5ddb57e6-932b-a52d-98aa-2d3ddd9995c8@redhat.com>
In-Reply-To: 1463415677-21183-1-git-send-email-laine@laine.org

--===============0938652454589179466==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

On 05/16/2016 12:21 PM, Laine Stump wrote:
> This is identical to type=3D'bridge', but without the "connect to a
> bridge" part, so it can be handled by using the same functions (and
> often even the same cases in switch statements), after renaming
> virLXCProcessSetupInterfaceBridged() to virLXCProcessInterfaceTap()
> and enhancing it to skip bridge-related items when brname =3D=3D NULL.
> =

> To be truly useful, we need to support setting the ip address on the
> host side veth as well as guest side veth (already supported for
> type=3D'bridge'), as well as setting the peer address for both.
> =

> The <script> element isn't supported in this patch because I have no
> need for it. I'd rather add it after determining it's needed rather
> than adding it for no reason and than being required to support it
> forever.

I suggest explicitly rejecting the <script> option then, since at least the
formatdomain docs make it sound like it's the only valid type=3Dethernet co=
nfig.
virLXCProcessSetupInterfaceTap seems like the only shared place for it thou=
gh

Also, this is https://bugzilla.redhat.com/show_bug.cgi?id=3D1325687

Patch looks fine otherwise, ACK if it's simple to reject the script bit, up=
 to you

- Cole


--===============0938652454589179466==--