4:02 a.m.
Ilias Stamatis (2):
test_driver: implement virDomainCreateWithFiles
test_driver: implement virDomainCreateXMLWithFile
src/test/test_driver.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
--
2.22.0
4:02 a.m.
New subject: [libvirt] [PATCH 1/2] test_driver: implement virDomainCreateWithFiles
This should just forward the call to testDomainCreateWithFlags since we
can't do anything with the provided file descriptors in the test driver.
Signed-off-by: Ilias Stamatis <stamatis.iliass(a)gmail.com>
---
src/test/test_driver.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index aae9875194..ea1febd960 100755
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -3948,6 +3948,16 @@ static int testDomainCreate(virDomainPtr domain)
return testDomainCreateWithFlags(domain, 0);
}
+
+static int testDomainCreateWithFiles(virDomainPtr domain,
+ unsigned int nfiles ATTRIBUTE_UNUSED,
+ int *files ATTRIBUTE_UNUSED,
+ unsigned int flags)
+{
+ return testDomainCreateWithFlags(domain, flags);
+}
+
+
static int testDomainUndefineFlags(virDomainPtr domain,
unsigned int flags)
{
@@ -8655,6 +8665,7 @@ static virHypervisorDriver testHypervisorDriver = {
.connectNumOfDefinedDomains = testConnectNumOfDefinedDomains, /* 0.1.11 */
.domainCreate = testDomainCreate, /* 0.1.11 */
.domainCreateWithFlags = testDomainCreateWithFlags, /* 0.8.2 */
+ .domainCreateWithFiles = testDomainCreateWithFiles, /* 5.7.0 */
.domainDefineXML = testDomainDefineXML, /* 0.1.11 */
.domainDefineXMLFlags = testDomainDefineXMLFlags, /* 1.2.12 */
.domainUndefine = testDomainUndefine, /* 0.1.11 */
--
2.22.0
4:02 a.m.
New subject: [libvirt] [PATCH 2/2] test_driver: implement virDomainCreateXMLWithFile
This should just forward the call to testDomainCreateXML since we
can't do anything with the provided file descriptors in the test driver.
Signed-off-by: Ilias Stamatis <stamatis.iliass(a)gmail.com>
---
src/test/test_driver.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index ea1febd960..b14ae51baa 100755
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -1684,6 +1684,17 @@ testDomainCreateXML(virConnectPtr conn, const char *xml,
}
+static virDomainPtr
+testDomainCreateXMLWithFiles(virConnectPtr conn,
+ const char *xml,
+ unsigned int nfiles ATTRIBUTE_UNUSED,
+ int *files ATTRIBUTE_UNUSED,
+ unsigned int flags)
+{
+ return testDomainCreateXML(conn, xml, flags);
+}
+
+
static virDomainPtr testDomainLookupByID(virConnectPtr conn,
int id)
{
@@ -8614,6 +8625,7 @@ static virHypervisorDriver testHypervisorDriver = {
.connectNumOfDomains = testConnectNumOfDomains, /* 0.1.1 */
.connectListAllDomains = testConnectListAllDomains, /* 0.9.13 */
.domainCreateXML = testDomainCreateXML, /* 0.1.4 */
+ .domainCreateXMLWithFiles = testDomainCreateXMLWithFiles, /* 5.7.0 */
.domainLookupByID = testDomainLookupByID, /* 0.1.1 */
.domainLookupByUUID = testDomainLookupByUUID, /* 0.1.1 */
.domainLookupByName = testDomainLookupByName, /* 0.1.1 */
--
2.22.0
4:15 a.m.
On Mon, Aug 05, 2019 at 11:02:21AM +0200, Ilias Stamatis wrote:
Ilias Stamatis (2):
test_driver: implement virDomainCreateWithFiles
test_driver: implement virDomainCreateXMLWithFile
src/test/test_driver.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
Reviewed-by: Erik Skultety <eskultet(a)redhat.com>
1938
days inactive
1938
days old
3 comments
2 participants
participants (2)
-
Erik Skultety -
Ilias Stamatis