On 26.09.2013 00:37, Jason Helfman wrote: > Libvirt no longer builds on FreeBSD 8.3. I had brought this up awhile > ago, but didn't have the resources to get the requested information. A > fellow committer was able to build, and send me an archive of the > complete build failure for analysis. > > Here is a link to build archive for investigation. > http://people.freebsd.org/~jgh/files/libvirt_83amd64.tar.xz D'oh! 403 - Forbidden Michal

make[3]: Entering directory `/home/zippy/work/tmp/a/libvirt-1.1.2/gnulib/lib' CC allocator.lo In file included from allocator.c:4:0: ./stdlib.h:76:8: error: redefinition of 'struct random_data' struct random_data ^ In file included from ./stdlib.h:36:0, from allocator.c:4: /usr/include/stdlib.h:349:8: note: originally defined here struct random_data ^ In file included from /usr/include/sys/types.h:220:0, from ./sys/types.h:27, from /usr/include/stdlib.h:320, from ./stdlib.h:36, from allocator.c:4: There are a few more but of the same nature. The problem is, gnulib's stdlib.h defines the struct random_data. And so does the system's /usr/include/stdlib.h. Unfortunately, I'm not that familiar with gnulib to fix the issue myself. Eric, any thoughts on this? Is it possible that your recent gnulib update has fixed this?

On Fri, Sep 27, 2013 at 4:57 AM, Eric Blake <eblake(a)redhat.com&gt; wrote: > On 09/27/2013 01:35 AM, Michal Privoznik wrote: >> >> make[3]: Entering directory >> `/home/zippy/work/tmp/a/libvirt-1.1.2/gnulib/lib' >> CC allocator.lo >> In file included from allocator.c:4:0: >> ./stdlib.h:76:8: error: redefinition of 'struct random_data' >> struct random_data >> ^ >> In file included from ./stdlib.h:36:0, >> from allocator.c:4: >> /usr/include/stdlib.h:349:8: note: originally defined here >> struct random_data >> ^

> Can > you show me the config.log output related to detecting whether 'struct > random_data' exists? Is this a case of circular header inclusion on > FreeBSD (that is, does <sys/types.h> try to recursively include > <stdlib.h> to pick up the struct?)

Should be available here: http://people.freebsd.org/~jgh/files/libvirt_83amd64.tar.xz

http://redports.org/~jgh/20130930154500-61365-148605/libvirt-1.1.2.log <http://redports.org/%7Ejgh/20130930154500-61365-148605/libvirt-1.1.2.log> However the build still fails, but looks to be a more standard failure

On 09/30/2013 10:09 AM, Jason Helfman wrote: >> So, what has to be included prior to <stdlib.h> for the forward >> declaration of struct random_data in that header to no longer be an >> incomplete type? Can you grep your system headers and find what all >> mentions struct random_data? >> >> > In looking through our 8.4 Branch, here are the results of digging the tree: > > crypto/openssh/pkcs11.h: unsigned char *random_data, > crypto/heimdal/lib/hx509/ref/pkcs11.h: unsigned char > *random_data, > crypto/heimdal/lib/hx509/hxtool.c:random_data(void *opt, int argc, char > **argv) > sys/netinet/sctp_output.c: > SCTP_READ_RANDOM(randp->random_data, random_len); Not relevant. > sys/netinet/sctp_header.h: uint8_t random_data[]; Maybe relevant. Can this header be picked up by some include sequence of standard-only headers, such that using <stdlib.h> in isolation doesn't have a problem, but <stdlib.h> in combination with this header causes the problem? > > Per another developer at FreeBSD, it seems to be a bug in 8.x branch and > picking up something it shouldn't and was "fixed" by adding this to the > configure environment: > ac_cv_type_struct_random_data="" Generally, Autoconf wants you to use 'ac_cv_type_struct_random_data=no', not blank. I don't know if using 'no' instead of a blank would resolve the compiler core dump you hit. Is there a mail archive where you were discussing this with the FreeBSD developers? > > http://redports.org/~jgh/20130930154500-61365-148605/libvirt-1.1.2.log Also, this build was on FreeBSD 8.4, although you reported the problem against FreeBSD 8.3. Let's get it resolved on one platform before bouncing around to another (at the moment, I only have a FreeBSD 8.2 environment for my own testing, so I'm not much help at the moment). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org

On Mon, Sep 30, 2013 at 2:27 PM, Jason Helfman <jgh(a)freebsd.org&gt; wrote: > On Mon, Sep 30, 2013 at 11:50 AM, Eric Blake <eblake(a)redhat.com&gt; wrote: >> >> On 09/30/2013 10:09 AM, Jason Helfman wrote: >> >> >> So, what has to be included prior to <stdlib.h> for the forward >> >> declaration of struct random_data in that header to no longer be an >> >> incomplete type? Can you grep your system headers and find what all >> >> mentions struct random_data? >> >> >> >> >> > In looking through our 8.4 Branch, here are the results of digging the >> > tree: >> > >> > crypto/openssh/pkcs11.h: unsigned char >> > *random_data, >> > crypto/heimdal/lib/hx509/ref/pkcs11.h: unsigned char >> > *random_data, >> > crypto/heimdal/lib/hx509/hxtool.c:random_data(void *opt, int argc, char >> > **argv) >> > sys/netinet/sctp_output.c: >> > SCTP_READ_RANDOM(randp->random_data, random_len); >> >> Not relevant. >> >> > sys/netinet/sctp_header.h: uint8_t random_data[]; >> >> Maybe relevant. Can this header be picked up by some include sequence >> of standard-only headers, such that using <stdlib.h> in isolation >> doesn't have a problem, but <stdlib.h> in combination with this header >> causes the problem? >> >> > >> > Per another developer at FreeBSD, it seems to be a bug in 8.x branch and >> > picking up something it shouldn't and was "fixed" by adding this to the >> > configure environment: >> > ac_cv_type_struct_random_data="" >> >> Generally, Autoconf wants you to use 'ac_cv_type_struct_random_data=no', >> not blank. I don't know if using 'no' instead of a blank would resolve >> the compiler core dump you hit. Is there a mail archive where you were >> discussing this with the FreeBSD developers? >> >> > >> > http://redports.org/~jgh/20130930154500-61365-148605/libvirt-1.1.2.log >> >> Also, this build was on FreeBSD 8.4, although you reported the problem >> against FreeBSD 8.3. Let's get it resolved on one platform before >> bouncing around to another (at the moment, I only have a FreeBSD 8.2 >> environment for my own testing, so I'm not much help at the moment). >> >> -- >> Eric Blake eblake redhat com +1-919-301-3266 >> Libvirt virtualization library http://libvirt.org >> > > It all uses the same branch of code, so it won't matter what version while > you are still in 8.x, unless you are running 8.x STABLE, and not a RELEASE > based branch. > > In working with a fellow developer, this came down to gcc bugs that were > addressed in later versions > of FreeBSD, but was not merged from CURRENT branch to 8.x. > > Here is a link to the fix that I will be committing at some point today. > > http://people.freebsd.org/~jgh/files/libvirt-84fix.diff > > Here are all the buildlogs, as well: > http://redports.org/buildarchive/20130930180500-15801/ > > -jgh > What's the error you're getting with -Wmissing-include-dirs? We should be testing to see if gcc supports that and not using it if its not supported. Additionally, what version of gcc are you using in 8.x? We can probably whip up a quick patch to resolve this.

As far as the struct random_data, I'll let Eric work on that since he's got a better understand and more context.