?Hi, here is a new patch. It propose to separate types of function by classes. For example : all virConnect[*] (virConnectOpen, virConnectNumOfDomains, etc...) functions are in the virConnect class. all virDomain[*] (virDomainCreate, virDomainDestroy, etc...) function are in the virDomain class. so we have these classes now : virConnect virDomain virEvent virInterface virLibrary virNetwork virNode virSecret virStoragePool virStorageVol virStream

?Okay, I'll make the change... Currently at naming level, my problem is around Error class. Do you have a suggestion ?

> >IMHO > >namespace LibvirtBindings >{ > public class virDomain > { > .... > >Is somewhat redundant and better named > >namespace Libvirt >{ > public class Domain > { > .... > > >The 'vir' prefix on C library APIs/structs is just a hack because C >does not have any concept of namespaces. It shouldn't be copied into >languages which do have proper namespace support >

?I just found "Error" too large for the person who will use C# bindings :S but... I can use Error, technically no problem. PS : I don't know exactly the english word, by too large I just want to avoid confusion -------------------------------------------------- From: "Daniel P. Berrange" <berrange(a)redhat.com&gt; Sent: Wednesday, October 20, 2010 2:21 PM To: <arnaud.champion(a)devatom.fr&gt; Cc: <libvir-list(a)redhat.com&gt; Subject: Re: [libvirt] [PATCH] C#Bindings patch, rename classes > On Wed, Oct 20, 2010 at 02:07:45PM +0200, arnaud.champion(a)devatom.fr > wrote: >> ?Okay, I'll make the change... Currently at naming level, my problem is >> around Error class. Do you have a suggestion ? > > What's wrong with following the example I gave, eg > > namespace Libvirt [ > > public class Error { > ... > >> > >> >IMHO >> > >> >namespace LibvirtBindings >> >{ >> > public class virDomain >> > { >> > .... >> > >> >Is somewhat redundant and better named >> > >> >namespace Libvirt >> >{ >> > public class Domain >> > { >> > .... >> > >> > >> >The 'vir' prefix on C library APIs/structs is just a hack because C >> >does not have any concept of namespaces. It shouldn't be copied into >> >languages which do have proper namespace support >> > > > Daniel > -- > |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ > :| > |: http://libvirt.org -o- http://virt-manager.org -o- > http://deltacloud.org :| > |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| > |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B > 9505 :| > -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

On Wed, Oct 20, 2010 at 02:56:37PM +0200, arnaud.champion(a)devatom.fr wrote: > ?virStream will expose problems also, as Stream is also a class in .Net > framework Why is that any problem ? Namespaces exist precisely to solve this problem. You only need name uniqueness within the namespace. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|