8:52 a.m.
virDomainMigrateFlags have errors
VIR_MIGRATE_LIVE have invalid comment and as i see all comments are
shifted down by one point.
--
Vasiliy Tolstov,
e-mail: v.tolstov(a)selfip.ru
7:30 a.m.
On 04/18/2017 03:52 PM, Vasiliy Tolstov wrote:
virDomainMigrateFlags have errors
VIR_MIGRATE_LIVE have invalid comment and as i see all comments are
shifted down by one point.
It's not just that. Basically anything that is the following form:
typedef enum {
/* description to value1 */
value1,
/* description to value2 */
value2,
};
The other example is:
https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainMemoryStatTags
Diggin' deeper, this is problem of apibuild.py script which also generates
docs/libvirt-api.xml. So our bindings have incorrect description for the values too. I am
looking into this now.
Michal
7:34 a.m.
2017-04-24 15:30 GMT+03:00 Michal Privoznik <mprivozn(a)redhat.com>:
Diggin' deeper, this is problem of apibuild.py script which also
generates docs/libvirt-api.xml. So our bindings have incorrect description for the values
too. I am looking into this now.
Thanks!
--
Vasiliy Tolstov,
e-mail: v.tolstov(a)selfip.ru
8:44 a.m.
On 04/24/2017 02:34 PM, Vasiliy Tolstov wrote:
2017-04-24 15:30 GMT+03:00 Michal Privoznik
<mprivozn(a)redhat.com>:
> Diggin' deeper, this is problem of apibuild.py script which also generates
docs/libvirt-api.xml. So our bindings have incorrect description for the values too. I am
looking into this now.
Thanks!
Actually, after seeing that python code, I give up. If somebody wants to
fix it, please do.
Michal
7:25 a.m.
On Mon, Apr 24, 2017 at 03:44:08PM +0200, Michal Privoznik wrote:
On 04/24/2017 02:34 PM, Vasiliy Tolstov wrote:
> 2017-04-24 15:30 GMT+03:00 Michal Privoznik <mprivozn(a)redhat.com>:
>> Diggin' deeper, this is problem of apibuild.py script which also generates
docs/libvirt-api.xml. So our bindings have incorrect description for the values too. I am
looking into this now.
>
>
> Thanks!
>
Actually, after seeing that python code, I give up. If somebody wants to
fix it, please do.
The code is not good. However, would it be easier if we just mandated
the order is:
comment
code
comment
code
comment
code
??
I know it worked before and it can be fixed, but the parsing is not nice
to work with. I'll have a look at it in the meantime.
Michal
--
libvir-list mailing list
libvir-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
2751
days inactive
2775
days old
4 comments
3 participants
participants (3)
-
Martin Kletzander -
Michal Privoznik -
Vasiliy Tolstov