10:40 p.m.
Andrea Bolognani (8):
guests: Fix PERL5LIB on Debian sid
guests: Simplify mapping for libtool
guests: Prepare Debian and Ubuntu to build more projects
guests: libosinfo needs libcurl and wget
guests: libvirt-dbus needs python3-gi
guests: virt-manager needs gtk-update-icon-cache
guests: Remove duplicate native packages
guests: Move native packages out of MinGW packages
guests/host_vars/libvirt-debian-8/main.yml | 1 +
guests/host_vars/libvirt-debian-sid/main.yml | 2 +-
guests/host_vars/libvirt-ubuntu-14/main.yml | 1 +
guests/host_vars/libvirt-ubuntu-16/main.yml | 2 ++
guests/vars/mappings.yml | 10 ++++++++--
guests/vars/projects/libosinfo+mingw.yml | 2 ++
guests/vars/projects/libosinfo.yml | 2 ++
guests/vars/projects/libvirt+mingw.yml | 2 --
guests/vars/projects/libvirt-dbus.yml | 1 +
guests/vars/projects/libvirt-glib+mingw.yml | 4 ----
guests/vars/projects/virt-manager.yml | 1 +
guests/vars/projects/virt-viewer+mingw.yml | 3 ---
guests/vars/projects/virt-viewer.yml | 1 +
13 files changed, 20 insertions(+), 12 deletions(-)
--
2.17.0
10:40 p.m.
New subject: [libvirt] [jenkins-ci PATCH 1/8] guests: Fix PERL5LIB on Debian sid
Debian sid is shipping Perl 5.26.2 now.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
guests/host_vars/libvirt-debian-sid/main.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/guests/host_vars/libvirt-debian-sid/main.yml
b/guests/host_vars/libvirt-debian-sid/main.yml
index f5eb52c..bc711f5 100644
--- a/guests/host_vars/libvirt-debian-sid/main.yml
+++ b/guests/host_vars/libvirt-debian-sid/main.yml
@@ -1,5 +1,5 @@
---
-PERL5LIB: $VIRT_PREFIX/lib/x86_64-linux-gnu/perl/5.26.1
+PERL5LIB: $VIRT_PREFIX/lib/x86_64-linux-gnu/perl/5.26.2
PYTHONPATH: $VIRT_PREFIX/lib/python3.6/site-packages
projects:
--
2.17.0
4:39 p.m.
New subject: [libvirt] [jenkins-ci PATCH 1/8] guests: Fix PERL5LIB on Debian sid
On Tue, May 15, 2018 at 04:40:02PM +0200, Andrea Bolognani wrote:
Debian sid is shipping Perl 5.26.2 now.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
guests/host_vars/libvirt-debian-sid/main.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/guests/host_vars/libvirt-debian-sid/main.yml
b/guests/host_vars/libvirt-debian-sid/main.yml
index f5eb52c..bc711f5 100644
--- a/guests/host_vars/libvirt-debian-sid/main.yml
+++ b/guests/host_vars/libvirt-debian-sid/main.yml
@@ -1,5 +1,5 @@
---
-PERL5LIB: $VIRT_PREFIX/lib/x86_64-linux-gnu/perl/5.26.1
+PERL5LIB: $VIRT_PREFIX/lib/x86_64-linux-gnu/perl/5.26.2
PYTHONPATH: $VIRT_PREFIX/lib/python3.6/site-packages
I guess that this is somehow needed otherwise the perl build fails
but we can use $(perl -e 'print substr($^V, 1)') to get the current
version.
Reviewed-by: Pavel Hrdina <phrdina(a)redhat.com>
6:34 p.m.
New subject: [libvirt] [jenkins-ci PATCH 1/8] guests: Fix PERL5LIB on Debian sid
On Wed, 2018-05-16 at 10:39 +0200, Pavel Hrdina wrote:
On Tue, May 15, 2018 at 04:40:02PM +0200, Andrea Bolognani wrote:
> -PERL5LIB: $VIRT_PREFIX/lib/x86_64-linux-gnu/perl/5.26.1
> +PERL5LIB: $VIRT_PREFIX/lib/x86_64-linux-gnu/perl/5.26.2
> PYTHONPATH: $VIRT_PREFIX/lib/python3.6/site-packages
I guess that this is somehow needed otherwise the perl build fails
but we can use $(perl -e 'print substr($^V, 1)') to get the current
version.
Good idea! I'll push the patch as-is for now, but I'll look into
integrating your suggestion and finding a Python equivalent so
that we can remove this last bit of per-host information from the
inventory.
--
Andrea Bolognani / Red Hat / Virtualization
10:40 p.m.
New subject: [libvirt] [jenkins-ci PATCH 2/8] guests: Simplify mapping for libtool
Ubuntu 14 is the only exception among Debian-based
distributions.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
guests/vars/mappings.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index cfba51c..fdab104 100644
--- a/guests/vars/mappings.yml
+++ b/guests/vars/mappings.yml
@@ -299,8 +299,8 @@ mappings:
libtool:
default: libtool
- Debian: libtool-bin
- Ubuntu16: libtool-bin
+ deb: libtool-bin
+ Ubuntu14: libtool
libtoolize:
default: libtool
--
2.17.0
4:39 p.m.
New subject: [libvirt] [jenkins-ci PATCH 2/8] guests: Simplify mapping for libtool
On Tue, May 15, 2018 at 04:40:03PM +0200, Andrea Bolognani wrote:
Ubuntu 14 is the only exception among Debian-based
distributions.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
guests/vars/mappings.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Pavel Hrdina <phrdina(a)redhat.com>
10:40 p.m.
New subject: [libvirt] [jenkins-ci PATCH 3/8] guests: Prepare Debian and Ubuntu to build more projects
osinfo-db and virt-manager can both be successfully built
on these platforms, so install the relative packages.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
guests/host_vars/libvirt-debian-8/main.yml | 1 +
guests/host_vars/libvirt-ubuntu-14/main.yml | 1 +
guests/host_vars/libvirt-ubuntu-16/main.yml | 2 ++
3 files changed, 4 insertions(+)
diff --git a/guests/host_vars/libvirt-debian-8/main.yml
b/guests/host_vars/libvirt-debian-8/main.yml
index bfd074d..cc91ef0 100644
--- a/guests/host_vars/libvirt-debian-8/main.yml
+++ b/guests/host_vars/libvirt-debian-8/main.yml
@@ -11,5 +11,6 @@ projects:
- libvirt-perl
- libvirt-python
- libvirt-tck
+ - osinfo-db
- osinfo-db-tools
- virt-viewer
diff --git a/guests/host_vars/libvirt-ubuntu-14/main.yml
b/guests/host_vars/libvirt-ubuntu-14/main.yml
index b404a5a..24e079c 100644
--- a/guests/host_vars/libvirt-ubuntu-14/main.yml
+++ b/guests/host_vars/libvirt-ubuntu-14/main.yml
@@ -8,5 +8,6 @@ projects:
- libvirt-perl
- libvirt-python
- libvirt-tck
+ - osinfo-db
- osinfo-db-tools
- virt-viewer
diff --git a/guests/host_vars/libvirt-ubuntu-16/main.yml
b/guests/host_vars/libvirt-ubuntu-16/main.yml
index 9aa5114..0760a0d 100644
--- a/guests/host_vars/libvirt-ubuntu-16/main.yml
+++ b/guests/host_vars/libvirt-ubuntu-16/main.yml
@@ -13,5 +13,7 @@ projects:
- libvirt-python
- libvirt-sandbox
- libvirt-tck
+ - osinfo-db
- osinfo-db-tools
+ - virt-manager
- virt-viewer
--
2.17.0
4:40 p.m.
New subject: [libvirt] [jenkins-ci PATCH 3/8] guests: Prepare Debian and Ubuntu to build more projects
On Tue, May 15, 2018 at 04:40:04PM +0200, Andrea Bolognani wrote:
osinfo-db and virt-manager can both be successfully built
on these platforms, so install the relative packages.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
guests/host_vars/libvirt-debian-8/main.yml | 1 +
guests/host_vars/libvirt-ubuntu-14/main.yml | 1 +
guests/host_vars/libvirt-ubuntu-16/main.yml | 2 ++
3 files changed, 4 insertions(+)
Reviewed-by: Pavel Hrdina <phrdina(a)redhat.com>
10:40 p.m.
New subject: [libvirt] [jenkins-ci PATCH 4/8] guests: libosinfo needs libcurl and wget
libcurl is used directly, and wget is used to retrieve PCI
and USB IDs at build time on platforms that don't ship them
as part of the operating system, such as MinGW.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
guests/vars/projects/libosinfo+mingw.yml | 3 +++
guests/vars/projects/libosinfo.yml | 1 +
2 files changed, 4 insertions(+)
diff --git a/guests/vars/projects/libosinfo+mingw.yml
b/guests/vars/projects/libosinfo+mingw.yml
index e3fc3cb..0eb27af 100644
--- a/guests/vars/projects/libosinfo+mingw.yml
+++ b/guests/vars/projects/libosinfo+mingw.yml
@@ -1,8 +1,11 @@
---
packages:
+ - mingw32-curl
- mingw32-glib2
- mingw32-libxml2
- mingw32-libxslt
+ - mingw64-curl
- mingw64-glib2
- mingw64-libxml2
- mingw64-libxslt
+ - wget
diff --git a/guests/vars/projects/libosinfo.yml b/guests/vars/projects/libosinfo.yml
index 1ecf483..4297110 100644
--- a/guests/vars/projects/libosinfo.yml
+++ b/guests/vars/projects/libosinfo.yml
@@ -6,6 +6,7 @@ packages:
- gobject-introspection
- gtk-doc
- intltool
+ - libcurl
- libsoup
- libxml2
- libxslt
--
2.17.0
4:44 p.m.
New subject: [libvirt] [jenkins-ci PATCH 4/8] guests: libosinfo needs libcurl and wget
On Tue, May 15, 2018 at 04:40:05PM +0200, Andrea Bolognani wrote:
libcurl is used directly, and wget is used to retrieve PCI
and USB IDs at build time on platforms that don't ship them
as part of the operating system, such as MinGW.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
guests/vars/projects/libosinfo+mingw.yml | 3 +++
guests/vars/projects/libosinfo.yml | 1 +
2 files changed, 4 insertions(+)
Reviewed-by: Pavel Hrdina <phrdina(a)redhat.com>
Note: minimal installation of CentOS doesn't ship wget by default so I
guess we might need to extend the list of dependencies. Currently it
works on CentOS 7 because we are building libvirt-cim which has wget as
explicit dependency.
5:24 p.m.
New subject: [libvirt] [jenkins-ci PATCH 4/8] guests: libosinfo needs libcurl and wget
On Wed, 2018-05-16 at 10:44 +0200, Pavel Hrdina wrote:
On Tue, May 15, 2018 at 04:40:05PM +0200, Andrea Bolognani wrote:
> libcurl is used directly, and wget is used to retrieve PCI
> and USB IDs at build time on platforms that don't ship them
> as part of the operating system, such as MinGW.
>
> Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
> ---
> guests/vars/projects/libosinfo+mingw.yml | 3 +++
> guests/vars/projects/libosinfo.yml | 1 +
> 2 files changed, 4 insertions(+)
Reviewed-by: Pavel Hrdina <phrdina(a)redhat.com>
Note: minimal installation of CentOS doesn't ship wget by default so I
guess we might need to extend the list of dependencies. Currently it
works on CentOS 7 because we are building libvirt-cim which has wget as
explicit dependency.
wget is only needed for MinGW builds, the native one uses the
contents of the pci-ids and usb-ids packages, which are
explicitly installed on CentOS as well as other native platforms.
So this is the only change that's needed.
--
Andrea Bolognani / Red Hat / Virtualization
10:40 p.m.
New subject: [libvirt] [jenkins-ci PATCH 5/8] guests: libvirt-dbus needs python3-gi
libvirt-glib is accessed through GObject Introspection
in the test suite.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
guests/vars/projects/libvirt-dbus.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/vars/projects/libvirt-dbus.yml
b/guests/vars/projects/libvirt-dbus.yml
index 4ae89f2..ebb346e 100644
--- a/guests/vars/projects/libvirt-dbus.yml
+++ b/guests/vars/projects/libvirt-dbus.yml
@@ -3,4 +3,5 @@ packages:
- glib2
- python3
- python3-dbus
+ - python3-gi
- python3-pytest
--
2.17.0
4:44 p.m.
New subject: [libvirt] [jenkins-ci PATCH 5/8] guests: libvirt-dbus needs python3-gi
On Tue, May 15, 2018 at 04:40:06PM +0200, Andrea Bolognani wrote:
libvirt-glib is accessed through GObject Introspection
in the test suite.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
guests/vars/projects/libvirt-dbus.yml | 1 +
1 file changed, 1 insertion(+)
Reviewed-by: Pavel Hrdina <phrdina(a)redhat.com>
10:40 p.m.
New subject: [libvirt] [jenkins-ci PATCH 6/8] guests: virt-manager needs gtk-update-icon-cache
It's used during installation.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
guests/vars/mappings.yml | 6 ++++++
guests/vars/projects/virt-manager.yml | 1 +
2 files changed, 7 insertions(+)
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index fdab104..dbffe23 100644
--- a/guests/vars/mappings.yml
+++ b/guests/vars/mappings.yml
@@ -164,6 +164,12 @@ mappings:
default: gtk-doc
deb: gtk-doc-tools
+ gtk-update-icon-cache:
+ default: gtk-update-icon-cache
+ Debian8: libgtk2.0-bin
+ Ubuntu14: libgtk2.0-bin
+ Ubuntu16: libgtk2.0-bin
+
gtk-vnc2:
deb: libgtk-vnc-2.0-dev
pkg: gtk-vnc
diff --git a/guests/vars/projects/virt-manager.yml
b/guests/vars/projects/virt-manager.yml
index e9e5324..9405fc6 100644
--- a/guests/vars/projects/virt-manager.yml
+++ b/guests/vars/projects/virt-manager.yml
@@ -1,5 +1,6 @@
---
packages:
+ - gtk-update-icon-cache
- intltool
- python3
- python3-gi
--
2.17.0
4:44 p.m.
New subject: [libvirt] [jenkins-ci PATCH 6/8] guests: virt-manager needs gtk-update-icon-cache
On Tue, May 15, 2018 at 04:40:07PM +0200, Andrea Bolognani wrote:
It's used during installation.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
guests/vars/mappings.yml | 6 ++++++
guests/vars/projects/virt-manager.yml | 1 +
2 files changed, 7 insertions(+)
Reviewed-by: Pavel Hrdina <phrdina(a)redhat.com>
10:40 p.m.
New subject: [libvirt] [jenkins-ci PATCH 7/8] guests: Remove duplicate native packages
The MinGW variant of a build can assume native dependencies
are installed, so no need to spell them out again.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
guests/vars/projects/libvirt+mingw.yml | 2 --
guests/vars/projects/libvirt-glib+mingw.yml | 4 ----
guests/vars/projects/virt-viewer+mingw.yml | 2 --
3 files changed, 8 deletions(-)
diff --git a/guests/vars/projects/libvirt+mingw.yml
b/guests/vars/projects/libvirt+mingw.yml
index 0dacb30..063e6a4 100644
--- a/guests/vars/projects/libvirt+mingw.yml
+++ b/guests/vars/projects/libvirt+mingw.yml
@@ -24,5 +24,3 @@ packages:
- mingw64-pkg-config
- mingw64-portablexdr
- mingw64-readline
- - rpcgen
- - xsltproc
diff --git a/guests/vars/projects/libvirt-glib+mingw.yml
b/guests/vars/projects/libvirt-glib+mingw.yml
index dec8e5c..49b9c6a 100644
--- a/guests/vars/projects/libvirt-glib+mingw.yml
+++ b/guests/vars/projects/libvirt-glib+mingw.yml
@@ -1,9 +1,5 @@
---
packages:
- - glib2
- - gobject-introspection
- - gtk-doc
- - intltool
- mingw32-glib2
- mingw64-glib2
- mingw32-libxml2
diff --git a/guests/vars/projects/virt-viewer+mingw.yml
b/guests/vars/projects/virt-viewer+mingw.yml
index be16f2c..5499dfe 100644
--- a/guests/vars/projects/virt-viewer+mingw.yml
+++ b/guests/vars/projects/virt-viewer+mingw.yml
@@ -1,8 +1,6 @@
---
packages:
- - glib2
- icoutils
- - intltool
- mingw32-glib2
- mingw32-glib-networking
- mingw32-gstreamer1-plugins-bad-free
--
2.17.0
4:49 p.m.
New subject: [libvirt] [jenkins-ci PATCH 7/8] guests: Remove duplicate native packages
On Tue, May 15, 2018 at 04:40:08PM +0200, Andrea Bolognani wrote:
The MinGW variant of a build can assume native dependencies
are installed, so no need to spell them out again.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
guests/vars/projects/libvirt+mingw.yml | 2 --
guests/vars/projects/libvirt-glib+mingw.yml | 4 ----
guests/vars/projects/virt-viewer+mingw.yml | 2 --
3 files changed, 8 deletions(-)
I'm not sure about this one, yes our setup runs mingw builds only on
systems where we run the native builds but we don't have it configured
as strict dependency.
Pavel
5:14 p.m.
New subject: [libvirt] [jenkins-ci PATCH 7/8] guests: Remove duplicate native packages
On Wed, 2018-05-16 at 10:49 +0200, Pavel Hrdina wrote:
On Tue, May 15, 2018 at 04:40:08PM +0200, Andrea Bolognani wrote:
> The MinGW variant of a build can assume native dependencies
> are installed, so no need to spell them out again.
>
> Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
> ---
> guests/vars/projects/libvirt+mingw.yml | 2 --
> guests/vars/projects/libvirt-glib+mingw.yml | 4 ----
> guests/vars/projects/virt-viewer+mingw.yml | 2 --
> 3 files changed, 8 deletions(-)
I'm not sure about this one, yes our setup runs mingw builds only on
systems where we run the native builds but we don't have it configured
as strict dependency.
There was a discussion about a very similar issue a while ago,
sparked by
https://www.redhat.com/archives/libvir-list/2018-April/msg01016.html
The bottom line for me is that non-native builds are something
you might decide to perform in addition to native builds (see
that + sign there? ;), so it's perfectly reasonable not to list
native dependencies for the MinGW variant.
It's true that we don't have a mechanism to ensure this
relationship is enforced, but as long as we don't start getting
a lot of external contributions I think reviews are a good
enough bar to clear.
I also plan to actually document this formally, along with the
other kind of relationship we need to concern ourselves with:
that between eg. libvirt-glib and libvirt, where the former can
only be built after building the latter, and as such doesn't
need to explicitly depend on any package the latter already
depends on. There's also some more cleaning up to do there, I
just haven't gotten around to it yet :)
--
Andrea Bolognani / Red Hat / Virtualization
6:27 p.m.
New subject: [libvirt] [jenkins-ci PATCH 7/8] guests: Remove duplicate native packages
On Wed, May 16, 2018 at 11:14:26AM +0200, Andrea Bolognani wrote:
On Wed, 2018-05-16 at 10:49 +0200, Pavel Hrdina wrote:
> On Tue, May 15, 2018 at 04:40:08PM +0200, Andrea Bolognani wrote:
> > The MinGW variant of a build can assume native dependencies
> > are installed, so no need to spell them out again.
> >
> > Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
> > ---
> > guests/vars/projects/libvirt+mingw.yml | 2 --
> > guests/vars/projects/libvirt-glib+mingw.yml | 4 ----
> > guests/vars/projects/virt-viewer+mingw.yml | 2 --
> > 3 files changed, 8 deletions(-)
>
> I'm not sure about this one, yes our setup runs mingw builds only on
> systems where we run the native builds but we don't have it configured
> as strict dependency.
There was a discussion about a very similar issue a while ago,
sparked by
https://www.redhat.com/archives/libvir-list/2018-April/msg01016.html
The bottom line for me is that non-native builds are something
you might decide to perform in addition to native builds (see
that + sign there? ;), so it's perfectly reasonable not to list
native dependencies for the MinGW variant.
It's true that we don't have a mechanism to ensure this
relationship is enforced, but as long as we don't start getting
a lot of external contributions I think reviews are a good
enough bar to clear.
I also plan to actually document this formally, along with the
other kind of relationship we need to concern ourselves with:
that between eg. libvirt-glib and libvirt, where the former can
only be built after building the latter, and as such doesn't
need to explicitly depend on any package the latter already
depends on. There's also some more cleaning up to do there, I
just haven't gotten around to it yet :)
Good enough for me :)
Reviewed-by: Pavel Hrdina <phrdina(a)redhat.com>
10:40 p.m.
New subject: [libvirt] [jenkins-ci PATCH 8/8] guests: Move native packages out of MinGW packages
Even though the packages are technically only needed when
performing a MinGW build, it doesn't hurt to have them
installed when performing native build, and keeping the
native packages all in one place is cleaner.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
guests/vars/projects/libosinfo+mingw.yml | 1 -
guests/vars/projects/libosinfo.yml | 1 +
guests/vars/projects/virt-viewer+mingw.yml | 1 -
guests/vars/projects/virt-viewer.yml | 1 +
4 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/guests/vars/projects/libosinfo+mingw.yml
b/guests/vars/projects/libosinfo+mingw.yml
index 0eb27af..8bf8622 100644
--- a/guests/vars/projects/libosinfo+mingw.yml
+++ b/guests/vars/projects/libosinfo+mingw.yml
@@ -8,4 +8,3 @@ packages:
- mingw64-glib2
- mingw64-libxml2
- mingw64-libxslt
- - wget
diff --git a/guests/vars/projects/libosinfo.yml b/guests/vars/projects/libosinfo.yml
index 4297110..dfbd004 100644
--- a/guests/vars/projects/libosinfo.yml
+++ b/guests/vars/projects/libosinfo.yml
@@ -13,4 +13,5 @@ packages:
- pci-ids
- usb-ids
- vala
+ - wget
- xmllint
diff --git a/guests/vars/projects/virt-viewer+mingw.yml
b/guests/vars/projects/virt-viewer+mingw.yml
index 5499dfe..c6aafd8 100644
--- a/guests/vars/projects/virt-viewer+mingw.yml
+++ b/guests/vars/projects/virt-viewer+mingw.yml
@@ -1,6 +1,5 @@
---
packages:
- - icoutils
- mingw32-glib2
- mingw32-glib-networking
- mingw32-gstreamer1-plugins-bad-free
diff --git a/guests/vars/projects/virt-viewer.yml b/guests/vars/projects/virt-viewer.yml
index cd32176..f9a2e78 100644
--- a/guests/vars/projects/virt-viewer.yml
+++ b/guests/vars/projects/virt-viewer.yml
@@ -3,6 +3,7 @@ packages:
- glib2
- gtk-vnc2
- gtk3
+ - icoutils
- intltool
- libgovirt
- libxml2
--
2.17.0
4:53 p.m.
New subject: [libvirt] [jenkins-ci PATCH 8/8] guests: Move native packages out of MinGW packages
On Tue, May 15, 2018 at 04:40:09PM +0200, Andrea Bolognani wrote:
Even though the packages are technically only needed when
performing a MinGW build, it doesn't hurt to have them
installed when performing native build, and keeping the
native packages all in one place is cleaner.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
guests/vars/projects/libosinfo+mingw.yml | 1 -
guests/vars/projects/libosinfo.yml | 1 +
guests/vars/projects/virt-viewer+mingw.yml | 1 -
guests/vars/projects/virt-viewer.yml | 1 +
4 files changed, 2 insertions(+), 2 deletions(-)
And I'm not sure about this one as well. Yes, it might make things
cleaner that the mingw dependencies are only mingw-* packages but it's
not correct. They are required only by the mingw build and not by the
regular build so it will pollute systems where we don't run mingw
builds.
Pavel
5:20 p.m.
New subject: [libvirt] [jenkins-ci PATCH 8/8] guests: Move native packages out of MinGW packages
On Wed, 2018-05-16 at 10:53 +0200, Pavel Hrdina wrote:
On Tue, May 15, 2018 at 04:40:09PM +0200, Andrea Bolognani wrote:
> Even though the packages are technically only needed when
> performing a MinGW build, it doesn't hurt to have them
> installed when performing native build, and keeping the
> native packages all in one place is cleaner.
>
> Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
> ---
> guests/vars/projects/libosinfo+mingw.yml | 1 -
> guests/vars/projects/libosinfo.yml | 1 +
> guests/vars/projects/virt-viewer+mingw.yml | 1 -
> guests/vars/projects/virt-viewer.yml | 1 +
> 4 files changed, 2 insertions(+), 2 deletions(-)
And I'm not sure about this one as well. Yes, it might make things
cleaner that the mingw dependencies are only mingw-* packages but it's
not correct. They are required only by the mingw build and not by the
regular build so it will pollute systems where we don't run mingw
builds.
I agree with your argument, to the point where I had basically
already acknowledged it in the commit message :)
Given how tiny the packages involved are, though, I think the
trade-off is worth it, especially in light of the stuff I
mentioned in the comments to the previous patch.
--
Andrea Bolognani / Red Hat / Virtualization
6:34 p.m.
New subject: [libvirt] [jenkins-ci PATCH 8/8] guests: Move native packages out of MinGW packages
On Wed, May 16, 2018 at 11:20:26AM +0200, Andrea Bolognani wrote:
On Wed, 2018-05-16 at 10:53 +0200, Pavel Hrdina wrote:
> On Tue, May 15, 2018 at 04:40:09PM +0200, Andrea Bolognani wrote:
> > Even though the packages are technically only needed when
> > performing a MinGW build, it doesn't hurt to have them
> > installed when performing native build, and keeping the
> > native packages all in one place is cleaner.
> >
> > Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
> > ---
> > guests/vars/projects/libosinfo+mingw.yml | 1 -
> > guests/vars/projects/libosinfo.yml | 1 +
> > guests/vars/projects/virt-viewer+mingw.yml | 1 -
> > guests/vars/projects/virt-viewer.yml | 1 +
> > 4 files changed, 2 insertions(+), 2 deletions(-)
>
> And I'm not sure about this one as well. Yes, it might make things
> cleaner that the mingw dependencies are only mingw-* packages but it's
> not correct. They are required only by the mingw build and not by the
> regular build so it will pollute systems where we don't run mingw
> builds.
I agree with your argument, to the point where I had basically
already acknowledged it in the commit message :)
Given how tiny the packages involved are, though, I think the
trade-off is worth it, especially in light of the stuff I
mentioned in the comments to the previous patch.
For me this is different issue than the previous patch. This actually
moves the dependency into project that doesn't require it out of project
that requires it. It's not like both will use it so it's safe and good
enough to have it in the parent project.
The only benefit that I can see is to have only mingw-* packages as
dependency of mingw builds, which might look nice and neat in the
configuration file but IMHO it's wrong. If we move them, it would be
nice to mention, that these packages are required by mingw build only
and that would feel weird, like why they are not only in the mingw
projects?
I would rather have it technically correct than having the configuration
files look nice :).
Pavel
6:48 p.m.
New subject: [libvirt] [jenkins-ci PATCH 8/8] guests: Move native packages out of MinGW packages
On Wed, 2018-05-16 at 12:34 +0200, Pavel Hrdina wrote:
On Wed, May 16, 2018 at 11:20:26AM +0200, Andrea Bolognani wrote:
> Given how tiny the packages involved are, though, I think the
> trade-off is worth it, especially in light of the stuff I
> mentioned in the comments to the previous patch.
For me this is different issue than the previous patch. This actually
moves the dependency into project that doesn't require it out of project
that requires it. It's not like both will use it so it's safe and good
enough to have it in the parent project.
The only benefit that I can see is to have only mingw-* packages as
dependency of mingw builds, which might look nice and neat in the
configuration file but IMHO it's wrong. If we move them, it would be
nice to mention, that these packages are required by mingw build only
and that would feel weird, like why they are not only in the mingw
projects?
I would rather have it technically correct than having the configuration
files look nice :).
As I said, it's a trade-off. But you clearly feel strongly on the
topic, and I kinda don't, so I'll just drop this patch :)
--
Andrea Bolognani / Red Hat / Virtualization
2361
days inactive
2362
days old
23 comments
2 participants
participants (2)
-
Andrea Bolognani -
Pavel Hrdina