[Libvir] [PATCH] Xen driver doesn't support autostart, so remove it from xen_unified
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2005 -----
- December
Our implementation of the Xen driver doesn't support autostart[*].
However xen_unified.c has a loop for get/setAutostart which causes it to
return an error without setting virterror first. This patch removes
that loop.
Rich.
[*] Although Xen supports it, by putting files in /etc/xen/autostart/
(at least that was the "old Xen" way before the current insanity of
getting rid of config files was invented).
--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in
England and Wales under Company Registration No. 03798903
Attachments:
- smime.p7s (application/x-pkcs7-signature — 3.2 KB)
- libvirt-xen-no-autostart-20070622.patch (text/x-patch — 1.6 KB)
On Fri, Jun 22, 2007 at 02:08:10PM +0100, Richard W.M. Jones wrote:
Our implementation of the Xen driver doesn't support autostart[*].
However xen_unified.c has a loop for get/setAutostart which causes it to
return an error without setting virterror first. This patch removes
that loop.
Rich.
[*] Although Xen supports it, by putting files in /etc/xen/autostart/
(at least that was the "old Xen" way before the current insanity of
getting rid of config files was invented).
Hum, if we are desesperate of ever adding the support to Xen,
then okay, but wouldn't it be better to emit the error before returning
in case no Xen sub-driver supports it ?
just wondering, +1 otherwise.
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
On Fri, Jun 22, 2007 at 02:08:10PM +0100, Richard W.M. Jones wrote:
Our implementation of the Xen driver doesn't support autostart[*].
However xen_unified.c has a loop for get/setAutostart which causes it to
return an error without setting virterror first. This patch removes
that loop.
Rich.
[*] Although Xen supports it, by putting files in /etc/xen/autostart/
(at least that was the "old Xen" way before the current insanity of
getting rid of config files was invented).
I can't remember the details offhand, but there's a new field in the
SEXPR for domains that lets you mark them as autostart, so we could
probably figure out some form of hacky implementation for the new
scheme. The old symlink way is easy- we just re-use the code from
the QEMU driver which does the same symlink magic
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
6363
days inactive
6363
days old
2 comments
3 participants
tags (0)
participants (3)
-
Daniel P. Berrange -
Daniel Veillard -
Richard W.M. Jones