[libvirt] [PATCH 0/2] Fix a couple of minor doc issues
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2005 -----
- December
The QE processing of the feature found a couple of minor doc type issues
so just fix an error message and add the command to the man page.
Both are rather trivial, but I can wait for reviews rather than push
directly as trivial..
John Ferlan (2):
conf: Fix typo in error message
virsh: Add source-protocol-ver to pool-define-as docs
src/conf/storage_conf.c | 2 +-
tools/virsh.pod | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
--
2.20.1
Monday, 29 April
Mon, 29 Apr
8 a.m.
New subject: [libvirt] [PATCH 1/2] conf: Fix typo in error message
Fix obvious typo.
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
src/conf/storage_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index 3ae0d7ab77..29988c36c4 100644
--- a/src/conf/storage_conf.c
+++ b/src/conf/storage_conf.c
@@ -666,7 +666,7 @@ virStoragePoolDefParseSource(xmlXPathContextPtr ctxt,
}
if (virStrToLong_uip(ver, NULL, 0, &source->protocolVer) < 0) {
virReportError(VIR_ERR_XML_ERROR,
- _("storage pool protocol ver '%s' is
malformaed"),
+ _("storage pool protocol ver '%s' is
malformed"),
ver);
goto cleanup;
}
--
2.20.1
8 a.m.
New subject: [libvirt] [PATCH 2/2] virsh: Add source-protocol-ver to pool-define-as docs
Commit a3dbaa364 neglected to add the source-protocol-ver to the
pool-define-as command.
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
tools/virsh.pod | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index afc1684db0..6bfeac6492 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -4013,6 +4013,7 @@ from the XML I<file>.
[I<--source-name name>] [I<--target path>] [I<--source-format format>]
[I<--auth-type authtype> I<--auth-username username>
[I<--secret-usage usage> | I<--secret-uuid uuid>]]
+[I<--source-protocol-ver ver>]
[[I<--adapter-name name>] | [I<--adapter-wwnn> I<--adapter-wwpn>]
[I<--adapter-parent parent>]] [I<--print-xml>]
--
2.20.1
On 4/29/19 3:00 PM, John Ferlan wrote:
The QE processing of the feature found a couple of minor doc type
issues
so just fix an error message and add the command to the man page.
Both are rather trivial, but I can wait for reviews rather than push
directly as trivial..
John Ferlan (2):
conf: Fix typo in error message
virsh: Add source-protocol-ver to pool-define-as docs
src/conf/storage_conf.c | 2 +-
tools/virsh.pod | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
ACK and safe for freeze.
Michal
2034
days inactive
2034
days old
3 comments
2 participants
tags (0)
participants (2)
-
John Ferlan -
Michal Privoznik