Re: [libvirt] [PATCH 2/3][ocaml] Add event callback implementation based on virConnectDomainEventRegisterAny

Thursday, 18 April 2013

Hi,

I just spotted a flaw in my OCaml event callback patch. I was hoping to
ensure the ocaml bindings build against libvirt 0.9.1 and later. For
functions, I remembered to include the usual symbol detection magic.
However I forgot that there are also some enums which were added later than
0.9.1 i.e. all of these:

On Wed, Apr 17, 2013 at 11:16 AM, David Scott <scott.dj(a)gmail.com&gt; wrote:

[snip]

...
 +  case VIR_DOMAIN_EVENT_ID_IO_ERROR_REASON:
 +    cb = VIR_DOMAIN_EVENT_CALLBACK(s_s_i_s_callback);
...
 +    break;
 +  case VIR_DOMAIN_EVENT_ID_CONTROL_ERROR:
 +    cb = VIR_DOMAIN_EVENT_CALLBACK(u_callback);
 +    break;
 +  case VIR_DOMAIN_EVENT_ID_BLOCK_JOB:
 +    cb = VIR_DOMAIN_EVENT_CALLBACK(s_i_i_callback);
 +    break;
 +  case VIR_DOMAIN_EVENT_ID_DISK_CHANGE:
 +    cb = VIR_DOMAIN_EVENT_CALLBACK(s_s_s_i_callback);
 +    break;
 +  case VIR_DOMAIN_EVENT_ID_TRAY_CHANGE:
 +    cb = VIR_DOMAIN_EVENT_CALLBACK(s_i_callback);
 +    break;
 +  case VIR_DOMAIN_EVENT_ID_PMWAKEUP:
 +    cb = VIR_DOMAIN_EVENT_CALLBACK(i_callback);
 +    break;
 +  case VIR_DOMAIN_EVENT_ID_PMSUSPEND:
 +    cb = VIR_DOMAIN_EVENT_CALLBACK(i_callback);
 +    break;
 +  case VIR_DOMAIN_EVENT_ID_BALLOON_CHANGE:
 +    cb = VIR_DOMAIN_EVENT_CALLBACK(i64_callback);
 +    break;
 +  case VIR_DOMAIN_EVENT_ID_PMSUSPEND_DISK:
 +    cb = VIR_DOMAIN_EVENT_CALLBACK(i_callback);
 +    break;

These currently cause the build to break against older libvirts.

I'll rework this and resubmit once I've verified it definitely does work
against an older version.

Sorry for the noise!

Cheers,
Dave

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005